From: Greg KH <gregkh@linuxfoundation.org>
To: Fabio Falzoi <fabio.falzoi84@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: rts5139: fix coding style
Date: Sun, 6 Apr 2014 17:33:41 -0700 [thread overview]
Message-ID: <20140407003341.GA13365@kroah.com> (raw)
In-Reply-To: <1396824306-20343-1-git-send-email-fabio.falzoi84@gmail.com>
On Mon, Apr 07, 2014 at 12:45:05AM +0200, Fabio Falzoi wrote:
> fix some coding style issues in rts51x.c (from rts5139 module)
What specific coding style issues did you fix here?
You need to be explicit, and if you do more than one type of change in
the same patch, it needs to be broken up into different patches.
Can you please resend this based on this?
thanks,
greg k-h
next prev parent reply other threads:[~2014-04-07 0:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-06 22:45 [PATCH] Staging: rts5139: fix coding style Fabio Falzoi
2014-04-07 0:33 ` Greg KH [this message]
2014-04-07 20:27 ` [PATCH v2 0/5] Staging: rts5139: Fix " Fabio Falzoi
2014-04-07 20:27 ` [PATCH v2 1/5] Staging: rts5139: Camel case labels replaced Fabio Falzoi
2014-04-07 20:27 ` [PATCH v2 2/5] Staging: rts5139: Fixed multi-line code alignment Fabio Falzoi
2014-04-07 20:27 ` [PATCH v2 3/5] Staging: rts5139: Splitted one-line multiple assignment Fabio Falzoi
2014-04-07 20:27 ` [PATCH v2 4/5] Staging: rts5139: pr_warn(...) in place of printk(KERN_WARNING ...) Fabio Falzoi
2014-04-07 20:34 ` Joe Perches
2014-04-07 20:56 ` Greg KH
2014-04-07 22:03 ` Joe Perches
2014-04-07 20:27 ` [PATCH v2 5/5] Staging: rts5139: More appropriate sizeof operand Fabio Falzoi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140407003341.GA13365@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=fabio.falzoi84@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).