From: "Stefan Lippers-Hollmann" <s.L-H@gmx.de>
To: driverdev-devel@linuxdriverproject.org
Cc: Josh Triplett <josh@joshtriplett.org>,
Jonas Hahnfeld <hahnjo@hahnjo.de>,
devel@driverdev.osuosl.org,
"Andreea-Cristina Bernat" <bernat.ada@gmail.com>,
Andrea Merello <andrea.merello@gmail.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
Ana Rey <anarey@gmail.com>,
linux-kernel@vger.kernel.org,
Paul Gortmaker <paul.gortmaker@windriver.com>,
Rashika Kheria <rashika.kheria@gmail.com>,
Teodora Baluta <teobaluta@gmail.com>,
Dan LaManna <dan.lamanna@gmail.com>,
Pablo Neira Ayuso <pablo@gnumonks.org>
Subject: Re: [PATCH] staging: rtl8187se: Fix warning symbol should be static
Date: Mon, 7 Apr 2014 01:34:42 +0000 [thread overview]
Message-ID: <201404070134.46030.s.L-H@gmx.de> (raw)
In-Reply-To: <20140406160903.GA8114@leaf>
Hi
On Sunday 06 April 2014, Josh Triplett wrote:
> On Sun, Apr 06, 2014 at 05:46:04PM +0200, Jonas Hahnfeld wrote:
> > This patch solves some sparse warnings about "symbol [...] was not
> > declared. Should it be static?" by including the correct header files.
> >
> > Signed-off-by: Jonas Hahnfeld <hahnjo@hahnjo.de>
>
> Reviewed-by: Josh Triplett <josh@joshtriplett.org>
[...]
Given that that rtl8187se support has already been merged mainline (for
3.15-rc1) into the existing rtl8180 (soon to be renamed to rtl818x)
driver, wouldn't it make more sense to remove
drivers/staging/rtl8187se/ rather than trying to fixing it?
commit 1eba648f998ef9c31b8cf062754a4a7b4ab9001f
Author: Andrea Merello <andrea.merello@gmail.com>
Date: Wed Mar 26 21:04:23 2014 +0100
rtl8180: enable rtl8187se support
Finally make rtl8187se works (hopefylly).
This patch adds PCI ID for rtl8187, updates copyright notes and
updates MODULE_DESCRIPTION.
Signed-off-by: Andrea Merello <andrea.merello@gmail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Regards
Stefan Lippers-Hollmann
next prev parent reply other threads:[~2014-04-07 1:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-06 15:46 [PATCH] staging: rtl8187se: Fix warning symbol should be static Jonas Hahnfeld
2014-04-06 16:09 ` Josh Triplett
2014-04-07 1:34 ` Stefan Lippers-Hollmann [this message]
2014-04-07 14:44 ` Jonas Hahnfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201404070134.46030.s.L-H@gmx.de \
--to=s.l-h@gmx.de \
--cc=anarey@gmail.com \
--cc=andrea.merello@gmail.com \
--cc=bernat.ada@gmail.com \
--cc=dan.lamanna@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=hahnjo@hahnjo.de \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pablo@gnumonks.org \
--cc=paul.gortmaker@windriver.com \
--cc=rashika.kheria@gmail.com \
--cc=teobaluta@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).