* [PATCH] staging: cxt1e1: hwprobe: fix incorrect type in assignment
@ 2014-03-23 12:13 Matei Oprea
2014-04-07 12:38 ` Matei Oprea
0 siblings, 1 reply; 4+ messages in thread
From: Matei Oprea @ 2014-03-23 12:13 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel, Matei Oprea, ROSEdu Kernel Community
This patch fixes "incorrect type in argument 1" warning from sparse.
Signed-off-by: Matei Oprea <eu@opreamatei.ro>
Cc: ROSEdu Kernel Community <firefly@lists.rosedu.org>
---
drivers/staging/cxt1e1/hwprobe.c | 6 +++---
drivers/staging/cxt1e1/pmcc4_private.h | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/cxt1e1/hwprobe.c b/drivers/staging/cxt1e1/hwprobe.c
index 9b4198b..1a145ea 100644
--- a/drivers/staging/cxt1e1/hwprobe.c
+++ b/drivers/staging/cxt1e1/hwprobe.c
@@ -174,12 +174,12 @@ cleanup_ioremap(void)
if (hi->pci_slot == 0xff)
break;
if (hi->addr_mapped[0]) {
- iounmap((void *)(hi->addr_mapped[0]));
+ iounmap(hi->addr_mapped[0]);
release_mem_region((long) hi->addr[0], hi->len[0]);
hi->addr_mapped[0] = 0;
}
if (hi->addr_mapped[1]) {
- iounmap((void *)(hi->addr_mapped[1]));
+ iounmap(hi->addr_mapped[1]);
release_mem_region((long) hi->addr[1], hi->len[1]);
hi->addr_mapped[1] = 0;
}
@@ -329,7 +329,7 @@ c4hw_attach_all(void)
return -ENOMEM;
}
- hi->addr_mapped[j] = (unsigned long)ioremap(hi->addr[j], hi->len[j]);
+ hi->addr_mapped[j] = ioremap(hi->addr[j], hi->len[j]);
if (!hi->addr_mapped[j]) {
pr_warning("%s: ioremap fails, addr=0x%lx, len=0x%lx ?\n",
hi->devname, hi->addr[j], hi->len[j]);
diff --git a/drivers/staging/cxt1e1/pmcc4_private.h b/drivers/staging/cxt1e1/pmcc4_private.h
index eb28f09..451f12f 100644
--- a/drivers/staging/cxt1e1/pmcc4_private.h
+++ b/drivers/staging/cxt1e1/pmcc4_private.h
@@ -262,7 +262,7 @@ struct s_hdw_info
struct pci_dev *pdev[2];
unsigned long addr[2];
- unsigned long addr_mapped[2];
+ void __iomem *addr_mapped[2];
unsigned long len[2];
union
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: cxt1e1: hwprobe: fix incorrect type in assignment
2014-03-23 12:13 [PATCH] staging: cxt1e1: hwprobe: fix incorrect type in assignment Matei Oprea
@ 2014-04-07 12:38 ` Matei Oprea
2014-04-07 14:14 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Matei Oprea @ 2014-04-07 12:38 UTC (permalink / raw)
To: Greg KH; +Cc: driverdev, linux-kernel, Matei Oprea, ROSEdu Kernel Community
Any comments on this ?
ᐧ
On Sun, Mar 23, 2014 at 2:13 PM, Matei Oprea <eu@opreamatei.ro> wrote:
> This patch fixes "incorrect type in argument 1" warning from sparse.
>
> Signed-off-by: Matei Oprea <eu@opreamatei.ro>
> Cc: ROSEdu Kernel Community <firefly@lists.rosedu.org>
> ---
> drivers/staging/cxt1e1/hwprobe.c | 6 +++---
> drivers/staging/cxt1e1/pmcc4_private.h | 2 +-
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/cxt1e1/hwprobe.c b/drivers/staging/cxt1e1/hwprobe.c
> index 9b4198b..1a145ea 100644
> --- a/drivers/staging/cxt1e1/hwprobe.c
> +++ b/drivers/staging/cxt1e1/hwprobe.c
> @@ -174,12 +174,12 @@ cleanup_ioremap(void)
> if (hi->pci_slot == 0xff)
> break;
> if (hi->addr_mapped[0]) {
> - iounmap((void *)(hi->addr_mapped[0]));
> + iounmap(hi->addr_mapped[0]);
> release_mem_region((long) hi->addr[0], hi->len[0]);
> hi->addr_mapped[0] = 0;
> }
> if (hi->addr_mapped[1]) {
> - iounmap((void *)(hi->addr_mapped[1]));
> + iounmap(hi->addr_mapped[1]);
> release_mem_region((long) hi->addr[1], hi->len[1]);
> hi->addr_mapped[1] = 0;
> }
> @@ -329,7 +329,7 @@ c4hw_attach_all(void)
> return -ENOMEM;
> }
>
> - hi->addr_mapped[j] = (unsigned long)ioremap(hi->addr[j], hi->len[j]);
> + hi->addr_mapped[j] = ioremap(hi->addr[j], hi->len[j]);
> if (!hi->addr_mapped[j]) {
> pr_warning("%s: ioremap fails, addr=0x%lx, len=0x%lx ?\n",
> hi->devname, hi->addr[j], hi->len[j]);
> diff --git a/drivers/staging/cxt1e1/pmcc4_private.h b/drivers/staging/cxt1e1/pmcc4_private.h
> index eb28f09..451f12f 100644
> --- a/drivers/staging/cxt1e1/pmcc4_private.h
> +++ b/drivers/staging/cxt1e1/pmcc4_private.h
> @@ -262,7 +262,7 @@ struct s_hdw_info
> struct pci_dev *pdev[2];
>
> unsigned long addr[2];
> - unsigned long addr_mapped[2];
> + void __iomem *addr_mapped[2];
> unsigned long len[2];
>
> union
> --
> 1.7.9.5
>
--
Oprea Matei
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: cxt1e1: hwprobe: fix incorrect type in assignment
2014-04-07 12:38 ` Matei Oprea
@ 2014-04-07 14:14 ` Greg KH
2014-04-07 14:28 ` Matei Oprea
0 siblings, 1 reply; 4+ messages in thread
From: Greg KH @ 2014-04-07 14:14 UTC (permalink / raw)
To: Matei Oprea; +Cc: driverdev, linux-kernel, ROSEdu Kernel Community
On Mon, Apr 07, 2014 at 03:38:27PM +0300, Matei Oprea wrote:
> Any comments on this ?
You got an email from me about this, on the 23rd, saying that I can't do
anything with it until 3.15-rc1 is out.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: cxt1e1: hwprobe: fix incorrect type in assignment
2014-04-07 14:14 ` Greg KH
@ 2014-04-07 14:28 ` Matei Oprea
0 siblings, 0 replies; 4+ messages in thread
From: Matei Oprea @ 2014-04-07 14:28 UTC (permalink / raw)
To: Greg KH; +Cc: driverdev, linux-kernel, ROSEdu Kernel Community
Sorry,
I thought that it's out.
ᐧ
On Mon, Apr 7, 2014 at 5:14 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Mon, Apr 07, 2014 at 03:38:27PM +0300, Matei Oprea wrote:
>> Any comments on this ?
>
> You got an email from me about this, on the 23rd, saying that I can't do
> anything with it until 3.15-rc1 is out.
>
> thanks,
>
> greg k-h
--
Oprea Matei
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-04-07 14:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-23 12:13 [PATCH] staging: cxt1e1: hwprobe: fix incorrect type in assignment Matei Oprea
2014-04-07 12:38 ` Matei Oprea
2014-04-07 14:14 ` Greg KH
2014-04-07 14:28 ` Matei Oprea
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).