From: Peter De Schrijver <pdeschrijver@nvidia.com>
To: Thierry Reding <treding@nvidia.com>
Cc: Mike Turquette <mturquette@linaro.org>,
Prashant Gaikwad <pgaikwad@nvidia.com>,
Stephen Warren <swarren@wwwdotorg.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/3] clk: tegra: Fix PLLE programming
Date: Mon, 7 Apr 2014 17:26:20 +0300 [thread overview]
Message-ID: <20140407142620.GA30476@tbergstrom-lnx.Nvidia.com> (raw)
In-Reply-To: <1396619715-15524-1-git-send-email-treding@nvidia.com>
On Fri, Apr 04, 2014 at 03:55:13PM +0200, Thierry Reding wrote:
> PLLE has M, N and P divider shift and width parameters that differ from
> the defaults. Furthermore, when clearing the M, N and P divider fields
> the corresponding masks were never shifted, thereby clearing only the
> lowest bits of the register. This lead to a situation where the PLLE
> programming would only work if the register hadn't been touched before.
>
Will take this into tegra-clk-next. Mike, given that this is bug fix for
a feature which is supposed to work, I think it's appropriate to try to get
this into 3.15 still. I will make a pull-request on 3.15-rc1 as soon as it
appears.
Cheers,
Peter.
prev parent reply other threads:[~2014-04-07 14:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-04 13:55 [PATCH v2 1/3] clk: tegra: Fix PLLE programming Thierry Reding
2014-04-04 13:55 ` [PATCH v2 2/3] clk: tegra: Introduce divider mask and shift helpers Thierry Reding
2014-04-04 13:55 ` [PATCH v2 3/3] clk: tegra: Fix enabling of PLLE Thierry Reding
2014-04-04 15:55 ` [PATCH v2 1/3] clk: tegra: Fix PLLE programming Stephen Warren
2014-04-07 14:26 ` Peter De Schrijver [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140407142620.GA30476@tbergstrom-lnx.Nvidia.com \
--to=pdeschrijver@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=pgaikwad@nvidia.com \
--cc=swarren@wwwdotorg.org \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox