From: Neil Horman <nhorman@tuxdriver.com>
To: Gerhard Sittig <gsi@denx.de>
Cc: "Yann Droneaud" <ydroneaud@opteya.com>,
"Hans-Bernhard Bröker" <broeker@users.sourceforge.net>,
linux-kernel@vger.kernel.org,
"Neil Horman" <nhorman@users.sourceforge.net>,
cscope-devel@lists.sourceforge.net,
"Anton Blanchard" <anton@samba.org>,
linuxppc-dev@lists.ozlabs.org,
"Hans-Bernhard Broeker" <broeker@physik.rwth-aachen.de>
Subject: Re: cscope: issue with symlinks in tools/testing/selftests/powerpc/copyloops/
Date: Mon, 7 Apr 2014 11:36:47 -0400 [thread overview]
Message-ID: <20140407153647.GA17258@hmsreliant.think-freely.org> (raw)
In-Reply-To: <20140407124259.GZ11339@book.gsilab.sittig.org>
On Mon, Apr 07, 2014 at 02:42:59PM +0200, Gerhard Sittig wrote:
> On Mon, 2014-04-07 at 06:42 -0400, Neil Horman wrote:
> >
> > On Thu, Apr 03, 2014 at 03:16:15PM +0200, Yann Droneaud wrote:
> > >
> > > [ ... ]
> > >
> > > cscope reports error when generating the cross-reference database:
> > >
> > > $ make ALLSOURCE_ARCHS=all O=./obj-cscope/ cscope
> > > GEN cscope
> > > cscope: cannot find
> > > file /home/ydroneaud/src/linux/tools/testing/selftests/powerpc/copyloops/copyuser_power7.S
> > > cscope: cannot find
> > > file /home/ydroneaud/src/linux/tools/testing/selftests/powerpc/copyloops/memcpy_64.S
> > > cscope: cannot find
> > > file /home/ydroneaud/src/linux/tools/testing/selftests/powerpc/copyloops/memcpy_power7.S
> > > cscope: cannot find
> > > file /home/ydroneaud/src/linux/tools/testing/selftests/powerpc/copyloops/copyuser_64.S
> > >
> > > And when calling cscope from ./obj-cscope/ directory, it reports errors
> > > too.
> > >
> > > Hopefully it doesn't stop it from working, so I'm still able to use
> > > cscope to browse kernel sources.
> > >
> > No, it won't stop it from working, it just won't search those files. I don't
> > recall exactly the reason, but IIRC there was a big discussion long ago about
> > symlinks and our ability to support them (around version 1.94 I think). We
> > decided to not handle symlinks, as they would either point outside our search
> > tree, which we didn't want to include, or would point to another file in the
> > search tree, which made loading them pointless (as we would cover the search in
> > the pointed file).
>
> So there are valid reasons to not process those filesystem
> entries. Would it be useful to not emit the warnings then? Or
> to silent those warnings when the user knows it's perfectly legal
> to skip those filesytem entries? Like what you can do with the
> ctags(1) command and its --links option.
>
I would see no problem with an option to do that. I'd like to make it opt-in,
so that people who want to know about symlink issues will still see them, but
I'd be supportive of an option to quiet them
Neil
>
> virtually yours
> Gerhard Sittig
> --
> DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr. 5, D-82194 Groebenzell, Germany
> Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office@denx.de
>
next prev parent reply other threads:[~2014-04-07 15:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-03 13:16 cscope: issue with symlinks in tools/testing/selftests/powerpc/copyloops/ Yann Droneaud
2014-04-07 10:42 ` Neil Horman
2014-04-07 12:42 ` Gerhard Sittig
2014-04-07 15:36 ` Neil Horman [this message]
2014-04-08 7:56 ` Gerhard Sittig
2014-04-08 10:49 ` Neil Horman
2014-05-02 1:19 ` Michael Ellerman
2014-05-21 13:32 ` [PATCH] scripts/tags.sh: ignore symlink'ed source files Yann Droneaud
2014-05-21 15:27 ` Neil Horman
2014-06-09 21:04 ` Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140407153647.GA17258@hmsreliant.think-freely.org \
--to=nhorman@tuxdriver.com \
--cc=anton@samba.org \
--cc=broeker@physik.rwth-aachen.de \
--cc=broeker@users.sourceforge.net \
--cc=cscope-devel@lists.sourceforge.net \
--cc=gsi@denx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nhorman@users.sourceforge.net \
--cc=ydroneaud@opteya.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox