From: Cyrill Gorcunov <gorcunov@openvz.org>
To: linux-kernel@vger.kernel.org
Cc: shawn@churchofgit.com, tglx@linutronix.de,
akpm@linux-foundation.org, avagin@openvz.org,
xemul@parallels.com, gorcunov@openvz.org, vdavydov@parallels.com
Subject: [patch 3/3] timerfd: Implement write method
Date: Mon, 07 Apr 2014 21:47:04 +0400 [thread overview]
Message-ID: <20140407174933.840538427@openvz.org> (raw)
In-Reply-To: 20140407174701.734703531@openvz.org
[-- Attachment #1: timerfd-write-ticks --]
[-- Type: text/plain, Size: 1659 bytes --]
The read() of timerfd files allows to fetch the number of
timer ticks while there is no way to set it back from userspace.
To restore the timer state as it was at checkpoint moment we need
a way to setup ticks back. So as a counterpart of read() the write()
takes ticks number from the userspace and updates internal timer
ticks accordingly.
CC: Shawn Landden <shawn@churchofgit.com>
CC: Thomas Gleixner <tglx@linutronix.de>
CC: Andrew Morton <akpm@linux-foundation.org>
CC: Andrey Vagin <avagin@openvz.org>
CC: Pavel Emelyanov <xemul@parallels.com>
CC: Vladimir Davydov <vdavydov@parallels.com>
Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
---
fs/timerfd.c | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
Index: linux-2.6.git/fs/timerfd.c
===================================================================
--- linux-2.6.git.orig/fs/timerfd.c
+++ linux-2.6.git/fs/timerfd.c
@@ -311,10 +311,31 @@ static int timerfd_show(struct seq_file
(unsigned long long)t.it_interval.tv_nsec);
}
+
+static ssize_t timerfd_write(struct file *file, const char __user *buf,
+ size_t count, loff_t *ppos)
+{
+ struct timerfd_ctx *ctx = file->private_data;
+ u64 ticks = 0;
+
+ if (count < sizeof(ticks))
+ return -EINVAL;
+
+ if (get_user(ticks, (u64 __user *) buf))
+ return -EFAULT;
+
+ spin_lock_irq(&ctx->wqh.lock);
+ ctx->ticks = ticks;
+ spin_unlock_irq(&ctx->wqh.lock);
+
+ return sizeof(ticks);
+}
+
static const struct file_operations timerfd_fops = {
.release = timerfd_release,
.poll = timerfd_poll,
.read = timerfd_read,
+ .write = timerfd_write,
.llseek = noop_llseek,
.show_fdinfo = timerfd_show,
};
next prev parent reply other threads:[~2014-04-07 17:49 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-07 17:47 [patch 0/3] timerfd -- implement missing parts to checkpoint and restore timerfd state, v2 Cyrill Gorcunov
2014-04-07 17:47 ` [patch 1/3] timerfd: Implement show_fdinfo method Cyrill Gorcunov
2014-04-08 6:17 ` Vladimir Davydov
2014-04-08 6:42 ` Cyrill Gorcunov
2014-04-08 6:54 ` Vladimir Davydov
2014-04-08 7:10 ` Cyrill Gorcunov
2014-04-07 17:47 ` [patch 2/3] docs: procfs -- Document timerfd output Cyrill Gorcunov
2014-04-08 7:43 ` [patch 2/3] docs: procfs -- Document timerfd output, v2 Cyrill Gorcunov
2014-04-08 7:52 ` Vladimir Davydov
2014-04-07 17:47 ` Cyrill Gorcunov [this message]
2014-04-28 20:53 ` [patch 0/3] timerfd -- implement missing parts to checkpoint and restore timerfd state, v2 Cyrill Gorcunov
2014-04-28 20:59 ` Thomas Gleixner
2014-04-28 21:03 ` Cyrill Gorcunov
-- strict thread matches above, loose matches on Subject: below --
2014-04-28 21:25 [patch 0/3] timerfd -- implement missing parts to checkpoint and restore timerfd state, v3 Cyrill Gorcunov
2014-04-28 21:25 ` [patch 3/3] timerfd: Implement write method Cyrill Gorcunov
2014-05-21 21:43 ` Thomas Gleixner
2014-05-21 21:57 ` Cyrill Gorcunov
2014-05-21 22:12 ` Thomas Gleixner
2014-05-21 22:35 ` Cyrill Gorcunov
2014-05-21 23:30 ` Thomas Gleixner
2014-05-22 5:31 ` Cyrill Gorcunov
2014-05-22 6:32 ` Michael Kerrisk
2014-05-22 7:03 ` Cyrill Gorcunov
[not found] ` <alpine.DEB.2.02.1405220643170.9695@ionos.tec.linutronix.de>
2014-05-21 21:58 ` Thomas Gleixner
2014-06-10 16:35 ` Cyrill Gorcunov
2014-06-10 20:03 ` Michael Kerrisk (man-pages)
2014-06-10 20:05 ` Andy Lutomirski
2014-06-10 20:22 ` Cyrill Gorcunov
2014-06-11 7:27 ` Andrew Vagin
2014-06-11 7:51 ` Cyrill Gorcunov
2014-06-11 9:09 ` Andrew Vagin
2014-06-11 9:52 ` Cyrill Gorcunov
2014-06-11 12:43 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140407174933.840538427@openvz.org \
--to=gorcunov@openvz.org \
--cc=akpm@linux-foundation.org \
--cc=avagin@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shawn@churchofgit.com \
--cc=tglx@linutronix.de \
--cc=vdavydov@parallels.com \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).