From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jean Delvare <jdelvare@suse.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] driver core: Move driver_data back to struct device
Date: Mon, 7 Apr 2014 13:58:15 -0700 [thread overview]
Message-ID: <20140407205815.GA8043@kroah.com> (raw)
In-Reply-To: <20140407105322.2eae6b97@endymion.delvare>
On Mon, Apr 07, 2014 at 10:53:22AM +0200, Jean Delvare wrote:
> Having to allocate memory as part of dev_set_drvdata() is a problem
> because that memory may never get freed if the device itself is not
> created. So move driver_data back to struct device.
>
> This is a partial revert of commit b4028437.
>
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> Greg, we discussed that back in January (in a thread named "Freeing of
> dev->p") but I did not hear back from you and I can't see this fix in
> your driver-core tree.
Thanks for doing this, I'll queue this up after -rc1 is out. I still
have that thread in my TODO list, unfortunatly, higher-priority items
keep bumping it down :(
greg k-h
next prev parent reply other threads:[~2014-04-07 20:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-07 8:53 [PATCH] driver core: Move driver_data back to struct device Jean Delvare
2014-04-07 20:58 ` Greg Kroah-Hartman [this message]
2014-04-10 7:50 ` Jean Delvare
2014-04-10 18:24 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140407205815.GA8043@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=jdelvare@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).