From: Dan Carpenter <dan.carpenter@oracle.com>
To: Jimmy Li <coder.liss@gmail.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Teodora Baluta" <teobaluta@gmail.com>,
"Joe Perches" <joe@perches.com>,
"Peter P Waskiewicz Jr" <peter.p.waskiewicz.jr@intel.com>,
"Michael Gunselmann" <michael.gunselmann@studium.uni-erlangen.de>,
"Lisa Nguyen" <lisa@xenapiadmin.com>,
"Martin Hofmann" <martin.hofmann@studium.uni-erlangen.de>,
"Malcolm Priestley" <tvboxspy@gmail.com>,
=?us-ascii?Q?=3D=3Futf-8=3FB=3FVMO8bGluIMSwemVy=3F=3D?=
<tulinizer@gmail.com>,
"Archana kumari" <archanakumari959@gmail.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] Staging: vt6655: iwctl.c: fix a sparse warning
Date: Tue, 8 Apr 2014 14:19:29 +0300 [thread overview]
Message-ID: <20140408111929.GG4963@mwanda> (raw)
In-Reply-To: <20140408110927.GA17308@gmail.com>
On Tue, Apr 08, 2014 at 07:09:27PM +0800, Jimmy Li wrote:
> thanks for correcting my patch format.
>
> Signed-off-by: Jimmy Li <coder.liss@gmail.com>
> ---
> v1 fix a sparse warning.
> (iwctl.c:1846:35: expected restricted gfp_t [usertype] flags)
> v2 clear up two unnecessary variable, buf and blen.
> v3 fix patch format.
> drivers/staging/vt6655/iwctl.c | 9 ++-------
> 1 file changed, 2 insertions(+), 7 deletions(-)
Please try applying your patch. Save the email as raw text including
headers and everything. `cat raw_email.txt | git am`. Then review the
log with `git log`. You'll see that the format is still messed up. :(
The part which should be discarded is saved and the part which should be
saved is deleted.
regards,
dan carpenter
next prev parent reply other threads:[~2014-04-08 11:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-08 11:09 [PATCH v3] Staging: vt6655: iwctl.c: fix a sparse warning Jimmy Li
2014-04-08 11:19 ` Dan Carpenter [this message]
2014-04-08 12:45 ` [PATCH v4] " Joe Perches
2014-04-08 14:26 ` [PATCH v5] " Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140408111929.GG4963@mwanda \
--to=dan.carpenter@oracle.com \
--cc=archanakumari959@gmail.com \
--cc=coder.liss@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lisa@xenapiadmin.com \
--cc=martin.hofmann@studium.uni-erlangen.de \
--cc=michael.gunselmann@studium.uni-erlangen.de \
--cc=peter.p.waskiewicz.jr@intel.com \
--cc=teobaluta@gmail.com \
--cc=tulinizer@gmail.com \
--cc=tvboxspy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox