public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Petr Vandrovec <petr@vandrovec.name>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
	Andrew Morton <akpm@linux-foundation.org>,
	Dave Chiluk <chiluk@canonical.com>,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] ncpfs: cleanup indenting in ncp_lookup()
Date: Tue, 8 Apr 2014 17:26:56 +0300	[thread overview]
Message-ID: <20140408142656.GI4963@mwanda> (raw)
In-Reply-To: <20140217201128.GA27455@elgon.mountain>

Ping?

regards,
dan carpenter

On Mon, Feb 17, 2014 at 11:11:28PM +0300, Dan Carpenter wrote:
> My static checker suggests adding curly braces here.  Probably that was
> the intent, but actually the code works the same either way.  I've just
> changed the indenting and left the code as-is.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> diff --git a/fs/ncpfs/dir.c b/fs/ncpfs/dir.c
> index 91441de2529c..08b8ea8c353e 100644
> --- a/fs/ncpfs/dir.c
> +++ b/fs/ncpfs/dir.c
> @@ -849,8 +849,8 @@ static struct dentry *ncp_lookup(struct inode *dir, struct dentry *dentry, unsig
>  				 dentry->d_name.len, 1);
>  		if (!res)
>  			res = ncp_lookup_volume(server, __name, &(finfo.i));
> -			if (!res)
> -				ncp_update_known_namespace(server, finfo.i.volNumber, NULL);
> +		if (!res)
> +			ncp_update_known_namespace(server, finfo.i.volNumber, NULL);
>  	} else {
>  		res = ncp_io2vol(server, __name, &len, dentry->d_name.name,
>  				 dentry->d_name.len, !ncp_preserve_case(dir));

      reply	other threads:[~2014-04-08 14:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-17 20:11 [patch] ncpfs: cleanup indenting in ncp_lookup() Dan Carpenter
2014-04-08 14:26 ` Dan Carpenter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140408142656.GI4963@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=chiluk@canonical.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=petr@vandrovec.name \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox