* [patch] ncpfs: cleanup indenting in ncp_lookup()
@ 2014-02-17 20:11 Dan Carpenter
2014-04-08 14:26 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2014-02-17 20:11 UTC (permalink / raw)
To: Petr Vandrovec
Cc: Al Viro, Andrew Morton, Dave Chiluk, linux-kernel,
kernel-janitors
My static checker suggests adding curly braces here. Probably that was
the intent, but actually the code works the same either way. I've just
changed the indenting and left the code as-is.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/fs/ncpfs/dir.c b/fs/ncpfs/dir.c
index 91441de2529c..08b8ea8c353e 100644
--- a/fs/ncpfs/dir.c
+++ b/fs/ncpfs/dir.c
@@ -849,8 +849,8 @@ static struct dentry *ncp_lookup(struct inode *dir, struct dentry *dentry, unsig
dentry->d_name.len, 1);
if (!res)
res = ncp_lookup_volume(server, __name, &(finfo.i));
- if (!res)
- ncp_update_known_namespace(server, finfo.i.volNumber, NULL);
+ if (!res)
+ ncp_update_known_namespace(server, finfo.i.volNumber, NULL);
} else {
res = ncp_io2vol(server, __name, &len, dentry->d_name.name,
dentry->d_name.len, !ncp_preserve_case(dir));
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] ncpfs: cleanup indenting in ncp_lookup()
2014-02-17 20:11 [patch] ncpfs: cleanup indenting in ncp_lookup() Dan Carpenter
@ 2014-04-08 14:26 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2014-04-08 14:26 UTC (permalink / raw)
To: Petr Vandrovec
Cc: Al Viro, Andrew Morton, Dave Chiluk, linux-kernel,
kernel-janitors
Ping?
regards,
dan carpenter
On Mon, Feb 17, 2014 at 11:11:28PM +0300, Dan Carpenter wrote:
> My static checker suggests adding curly braces here. Probably that was
> the intent, but actually the code works the same either way. I've just
> changed the indenting and left the code as-is.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/fs/ncpfs/dir.c b/fs/ncpfs/dir.c
> index 91441de2529c..08b8ea8c353e 100644
> --- a/fs/ncpfs/dir.c
> +++ b/fs/ncpfs/dir.c
> @@ -849,8 +849,8 @@ static struct dentry *ncp_lookup(struct inode *dir, struct dentry *dentry, unsig
> dentry->d_name.len, 1);
> if (!res)
> res = ncp_lookup_volume(server, __name, &(finfo.i));
> - if (!res)
> - ncp_update_known_namespace(server, finfo.i.volNumber, NULL);
> + if (!res)
> + ncp_update_known_namespace(server, finfo.i.volNumber, NULL);
> } else {
> res = ncp_io2vol(server, __name, &len, dentry->d_name.name,
> dentry->d_name.len, !ncp_preserve_case(dir));
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-04-08 14:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-17 20:11 [patch] ncpfs: cleanup indenting in ncp_lookup() Dan Carpenter
2014-04-08 14:26 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox