From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757271AbaDHO1P (ORCPT ); Tue, 8 Apr 2014 10:27:15 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:49125 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757197AbaDHO1N (ORCPT ); Tue, 8 Apr 2014 10:27:13 -0400 Date: Tue, 8 Apr 2014 17:26:56 +0300 From: Dan Carpenter To: Petr Vandrovec Cc: Al Viro , Andrew Morton , Dave Chiluk , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [patch] ncpfs: cleanup indenting in ncp_lookup() Message-ID: <20140408142656.GI4963@mwanda> References: <20140217201128.GA27455@elgon.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140217201128.GA27455@elgon.mountain> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: ucsinet21.oracle.com [156.151.31.93] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ping? regards, dan carpenter On Mon, Feb 17, 2014 at 11:11:28PM +0300, Dan Carpenter wrote: > My static checker suggests adding curly braces here. Probably that was > the intent, but actually the code works the same either way. I've just > changed the indenting and left the code as-is. > > Signed-off-by: Dan Carpenter > > diff --git a/fs/ncpfs/dir.c b/fs/ncpfs/dir.c > index 91441de2529c..08b8ea8c353e 100644 > --- a/fs/ncpfs/dir.c > +++ b/fs/ncpfs/dir.c > @@ -849,8 +849,8 @@ static struct dentry *ncp_lookup(struct inode *dir, struct dentry *dentry, unsig > dentry->d_name.len, 1); > if (!res) > res = ncp_lookup_volume(server, __name, &(finfo.i)); > - if (!res) > - ncp_update_known_namespace(server, finfo.i.volNumber, NULL); > + if (!res) > + ncp_update_known_namespace(server, finfo.i.volNumber, NULL); > } else { > res = ncp_io2vol(server, __name, &len, dentry->d_name.name, > dentry->d_name.len, !ncp_preserve_case(dir));