public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Michal Marek <mmarek@suse.cz>
To: Jason Cooper <jason@lakedaemon.net>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Joe Perches <joe@perches.com>,
	"Yann E . MORIN" <yann.morin.1998@free.fr>,
	Rusty Russell <rusty@rustcorp.com.au>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3] scripts: objdiff: detect object code changes between two commits
Date: Tue, 8 Apr 2014 16:43:59 +0200	[thread overview]
Message-ID: <20140408144359.GA4894@sepie.suse.cz> (raw)
In-Reply-To: <1396895429-27425-1-git-send-email-jason@lakedaemon.net>

On Mon, Apr 07, 2014 at 06:30:29PM +0000, Jason Cooper wrote:
> objdiff is useful when doing large code cleanups.  For example, when
> removing checkpatch warnings and errors from new drivers in the staging
> tree.
> 
> objdiff can be used in conjunction with a git rebase to confirm that
> each commit made no changes to the resulting object code.  It has the
> same return values as diff(1).
> 
> This was written specifically to support adding the skein and threefish
> cryto drivers to the staging tree.  I needed a programmatic way to
> confirm that commits changing >90% of the lines didn't inadvertently
> change the code.
> 
> Temporary files (objdump output) are stored in
> 
>   /path/to/linux/.tmp_objdiff
> 
> 'make mrproper' will remove this directory.
> 
> Signed-off-by: Jason Cooper <jason@lakedaemon.net>
> ---
> Changes from V2:
> 
>  - use /path/to/linux/.tmp_objdiff instead of /tmp/objdiff (Michal Marek)
> 
>  - don't delete object files during record (Michal Marek)
> 
>  - remove .tmp_objdiff directory during 'make mrproper' (Michal Marek)

Applied to kbuild.git#misc, thanks.

Michal

      reply	other threads:[~2014-04-08 14:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-24  2:14 [PATCH V2] scripts: objdiff: detect object code changes between two commits Jason Cooper
2014-03-29 21:31 ` Michal Marek
2014-04-07 18:30 ` [PATCH V3] " Jason Cooper
2014-04-08 14:43   ` Michal Marek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140408144359.GA4894@sepie.suse.cz \
    --to=mmarek@suse.cz \
    --cc=akpm@linux-foundation.org \
    --cc=jason@lakedaemon.net \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    --cc=yann.morin.1998@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox