From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org,
linux-rt-users <linux-rt-users@vger.kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Carsten Emde <C.Emde@osadl.org>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
John Kacur <jkacur@redhat.com>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: [PATCH RT 0/2] rwsem-rt: Make rwsem rt closer to mainline
Date: Tue, 08 Apr 2014 22:47:00 -0400 [thread overview]
Message-ID: <20140409024700.702797305@goodmis.org> (raw)
Looking at mainline's down_read() I noticed that reader locks of rwsems
are not made to nest. In fact, they should not. Although, it may seem
fine if a down_read() nests as multiple readers can have the lock,
rwsems are fair locks. That is, if a writer were to block on a rwsem
while readers have the lock, a new reader will also block. If a reader
were to try to take the lock again while a writer was waiting, it
would block, and cause a deadlock as it has the lock its trying
to grab and wont let it go as the writer is waiting.
I also found that the rt_mutex_init() is identical in the two places
it is defined in rtmutex.h.
Steven Rostedt (Red Hat) (2):
rwsem-rt: Do not allow readers to nest
rtmutex: Remove duplicate rt_mutex_init()
----
include/linux/rtmutex.h | 12 +++---------
include/linux/rwsem_rt.h | 1 -
kernel/rt.c | 37 ++++++++-----------------------------
3 files changed, 11 insertions(+), 39 deletions(-)
next reply other threads:[~2014-04-09 2:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-09 2:47 Steven Rostedt [this message]
2014-04-09 2:47 ` [PATCH RT 1/2] rwsem-rt: Do not allow readers to nest Steven Rostedt
2014-05-02 9:04 ` Sebastian Andrzej Siewior
2015-02-18 19:57 ` Sebastian Andrzej Siewior
2015-02-18 20:13 ` Steven Rostedt
2015-02-20 5:07 ` Jason Low
2015-02-25 12:15 ` Sebastian Andrzej Siewior
2014-04-09 2:47 ` [PATCH RT 2/2] rtmutex: Remove duplicate rt_mutex_init() Steven Rostedt
2014-05-02 9:08 ` Sebastian Andrzej Siewior
2014-05-02 13:12 ` Steven Rostedt
2014-05-02 13:21 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140409024700.702797305@goodmis.org \
--to=rostedt@goodmis.org \
--cc=C.Emde@osadl.org \
--cc=a.p.zijlstra@chello.nl \
--cc=bigeasy@linutronix.de \
--cc=hpa@zytor.com \
--cc=jkacur@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox