From: Matt Fleming <matt@console-pimps.org>
To: Koen Kooi <koen@dominion.thruhere.net>
Cc: Matt Fleming <matt.fleming@intel.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
x86@kernel.org, Kees Cook <keescook@chromium.org>,
Zhang Yanfei <zhangyanfei@cn.fujitsu.com>,
linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: "54b52d87268034859191d671505bb1cfce6bd74d - x86/efi: Build our own EFI services pointer table" breaks boot on thinkpad t440s
Date: Thu, 10 Apr 2014 13:11:46 +0100 [thread overview]
Message-ID: <20140410121146.GA17021@console-pimps.org> (raw)
In-Reply-To: <AF4406ED-6B0B-4E15-A329-04162E0ADC8A@dominion.thruhere.net>
On Thu, 10 Apr, at 12:43:43PM, Koen Kooi wrote:
> Hi,
>
> After updating from 3.14-rc7 to a recent git the kernel fails to boot on my thinkpad t440s and displays:
>
> Failed to get file info size
> Failed to alloc highmem for files
>
> After a morning of running git bisect and rebooting, the bad commit seems to be:
>
> 54b52d87268034859191d671505bb1cfce6bd74d - x86/efi: Build our own EFI services pointer table
Thanks for the report. Can you try this patch against Linus' tree?
diff --git a/arch/x86/boot/compressed/eboot.c b/arch/x86/boot/compressed/eboot.c
index 1e6146137f8e..280165524ee4 100644
--- a/arch/x86/boot/compressed/eboot.c
+++ b/arch/x86/boot/compressed/eboot.c
@@ -112,7 +112,7 @@ __file_size64(void *__fh, efi_char16_t *filename_16,
efi_file_info_t *info;
efi_status_t status;
efi_guid_t info_guid = EFI_FILE_INFO_ID;
- u32 info_sz;
+ u64 info_sz;
status = efi_early->call((unsigned long)fh->open, fh, &h, filename_16,
EFI_FILE_MODE_READ, (u64)0);
--
Matt Fleming, Intel Open Source Technology Center
next prev parent reply other threads:[~2014-04-10 12:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-10 10:43 "54b52d87268034859191d671505bb1cfce6bd74d - x86/efi: Build our own EFI services pointer table" breaks boot on thinkpad t440s Koen Kooi
2014-04-10 12:11 ` Matt Fleming [this message]
2014-04-10 12:24 ` Koen Kooi
2014-04-11 7:20 ` Ingo Molnar
2014-04-11 7:44 ` Matt Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140410121146.GA17021@console-pimps.org \
--to=matt@console-pimps.org \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=koen@dominion.thruhere.net \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=zhangyanfei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox