From: Al Viro <viro@ZenIV.linux.org.uk>
To: Paul McQuade <paulmcquad@gmail.com>
Cc: linux-kernel@vger.kernel.org, jack@suse.cz
Subject: Re: [PATCH 11/15] kernel:acct:spaces required
Date: Thu, 10 Apr 2014 20:36:41 +0100 [thread overview]
Message-ID: <20140410193641.GE18016@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1397156046-6837-1-git-send-email-paulmcquad@gmail.com>
On Thu, Apr 10, 2014 at 07:54:06PM +0100, Paul McQuade wrote:
> ERROR: spaces required around that '>' (ctx:VxV)
Egads, man...
a) ERROR (in ALL CAPS, no less) according to whom? Sure, it's nicer to
add those spaces, but do you really think that it deserves a separate
patch, especially with such a commit message?
b) AFAICS, you've posted at least 4 such one-liners to kernel/acct.c, with
commit messages that sound like "Because The Most Holy sendpatch.pl (All Praise
sendpatch.pl) Says So". There might be some reason to split the
asm/uaccess.h -> linux/uaccess.h replacement into a separate commit, but
the rest of that? Come on...
Trivial whitespace, etc. changes like that should be clearly marked as such
and not split beyond reasonable...
prev parent reply other threads:[~2014-04-10 19:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-10 18:54 [PATCH 11/15] kernel:acct:spaces required Paul McQuade
2014-04-10 19:36 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140410193641.GE18016@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmcquad@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox