* [PATCH] serial: imx: replace IS_ERR and PTR_ERR with PTR_ERR_OR_ZERO
@ 2014-04-11 8:38 Duan Jiong
2014-04-13 8:00 ` Shawn Guo
0 siblings, 1 reply; 2+ messages in thread
From: Duan Jiong @ 2014-04-11 8:38 UTC (permalink / raw)
To: shawn.guo, kernel, linux; +Cc: linux-kernel, Duan Jiong
This patch fixes coccinelle error regarding usage of IS_ERR and
PTR_ERR instead of PTR_ERR_OR_ZERO.
Signed-off-by: Duan Jiong <duanj.fnst@cn.fujitsu.com>
---
arch/arm/mach-imx/mach-mx31moboard.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/arch/arm/mach-imx/mach-mx31moboard.c b/arch/arm/mach-imx/mach-mx31moboard.c
index 8f45afe..c05d711 100644
--- a/arch/arm/mach-imx/mach-mx31moboard.c
+++ b/arch/arm/mach-imx/mach-mx31moboard.c
@@ -434,10 +434,7 @@ static int __init moboard_usbh2_init(void)
return -ENODEV;
pdev = imx31_add_mxc_ehci_hs(2, &usbh2_pdata);
- if (IS_ERR(pdev))
- return PTR_ERR(pdev);
-
- return 0;
+ return PTR_ERR_OR_ZERO(pdev);
}
static const struct gpio_led mx31moboard_leds[] __initconst = {
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] serial: imx: replace IS_ERR and PTR_ERR with PTR_ERR_OR_ZERO
2014-04-11 8:38 [PATCH] serial: imx: replace IS_ERR and PTR_ERR with PTR_ERR_OR_ZERO Duan Jiong
@ 2014-04-13 8:00 ` Shawn Guo
0 siblings, 0 replies; 2+ messages in thread
From: Shawn Guo @ 2014-04-13 8:00 UTC (permalink / raw)
To: Duan Jiong; +Cc: kernel, linux, linux-kernel
On Fri, Apr 11, 2014 at 04:38:42PM +0800, Duan Jiong wrote:
> This patch fixes coccinelle error regarding usage of IS_ERR and
> PTR_ERR instead of PTR_ERR_OR_ZERO.
>
> Signed-off-by: Duan Jiong <duanj.fnst@cn.fujitsu.com>
> ---
> arch/arm/mach-imx/mach-mx31moboard.c | 5 +----
You are patching a board file under arch/arm/mach-imx, but have the
patch prefixed with "serial:". This is quite confusing.
You may want to just merge the change into the one you sent to change
mx31moboard-smartbot.c.
Shawn
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/arch/arm/mach-imx/mach-mx31moboard.c b/arch/arm/mach-imx/mach-mx31moboard.c
> index 8f45afe..c05d711 100644
> --- a/arch/arm/mach-imx/mach-mx31moboard.c
> +++ b/arch/arm/mach-imx/mach-mx31moboard.c
> @@ -434,10 +434,7 @@ static int __init moboard_usbh2_init(void)
> return -ENODEV;
>
> pdev = imx31_add_mxc_ehci_hs(2, &usbh2_pdata);
> - if (IS_ERR(pdev))
> - return PTR_ERR(pdev);
> -
> - return 0;
> + return PTR_ERR_OR_ZERO(pdev);
> }
>
> static const struct gpio_led mx31moboard_leds[] __initconst = {
> --
> 1.8.3.1
>
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-04-13 8:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-11 8:38 [PATCH] serial: imx: replace IS_ERR and PTR_ERR with PTR_ERR_OR_ZERO Duan Jiong
2014-04-13 8:00 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox