* [PATCH] pinctrl: pinctrl-imx: Print the mux_mode field in hex format
@ 2014-04-13 15:09 Fabio Estevam
2014-04-14 1:21 ` Shawn Guo
2014-04-22 13:11 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Fabio Estevam @ 2014-04-13 15:09 UTC (permalink / raw)
To: linus.walleij; +Cc: shawn.guo, linux-kernel, Fabio Estevam
From: Fabio Estevam <fabio.estevam@freescale.com>
With debug enabled we get better readability dumps of the mux_mode register if
we use hexadecimal format instead:
imx6sl-pinctrl 20e0000.iomuxc: MX6SL_PAD_FEC_REF_CLK: 0x10 0x0001b0a8
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
drivers/pinctrl/pinctrl-imx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/pinctrl-imx.c b/drivers/pinctrl/pinctrl-imx.c
index e118fb1..a24448e 100644
--- a/drivers/pinctrl/pinctrl-imx.c
+++ b/drivers/pinctrl/pinctrl-imx.c
@@ -491,7 +491,7 @@ static int imx_pinctrl_parse_groups(struct device_node *np,
pin->mux_mode |= IOMUXC_CONFIG_SION;
pin->config = config & ~IMX_PAD_SION;
- dev_dbg(info->dev, "%s: %d 0x%08lx", info->pins[pin_id].name,
+ dev_dbg(info->dev, "%s: 0x%x 0x%08lx", info->pins[pin_id].name,
pin->mux_mode, pin->config);
}
--
1.8.3.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: pinctrl-imx: Print the mux_mode field in hex format
2014-04-13 15:09 [PATCH] pinctrl: pinctrl-imx: Print the mux_mode field in hex format Fabio Estevam
@ 2014-04-14 1:21 ` Shawn Guo
2014-04-22 13:11 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2014-04-14 1:21 UTC (permalink / raw)
To: Fabio Estevam; +Cc: linus.walleij, linux-kernel, Fabio Estevam
On Sun, Apr 13, 2014 at 12:09:05PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> With debug enabled we get better readability dumps of the mux_mode register if
> we use hexadecimal format instead:
>
> imx6sl-pinctrl 20e0000.iomuxc: MX6SL_PAD_FEC_REF_CLK: 0x10 0x0001b0a8
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Acked-by: Shawn Guo <shawn.guo@freescale.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: pinctrl-imx: Print the mux_mode field in hex format
2014-04-13 15:09 [PATCH] pinctrl: pinctrl-imx: Print the mux_mode field in hex format Fabio Estevam
2014-04-14 1:21 ` Shawn Guo
@ 2014-04-22 13:11 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2014-04-22 13:11 UTC (permalink / raw)
To: Fabio Estevam; +Cc: Shawn Guo, linux-kernel@vger.kernel.org, Fabio Estevam
On Sun, Apr 13, 2014 at 5:09 PM, Fabio Estevam <festevam@gmail.com> wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> With debug enabled we get better readability dumps of the mux_mode register if
> we use hexadecimal format instead:
>
> imx6sl-pinctrl 20e0000.iomuxc: MX6SL_PAD_FEC_REF_CLK: 0x10 0x0001b0a8
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Patch applied with Shawn's ACK.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-04-22 13:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-13 15:09 [PATCH] pinctrl: pinctrl-imx: Print the mux_mode field in hex format Fabio Estevam
2014-04-14 1:21 ` Shawn Guo
2014-04-22 13:11 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox