From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754426AbaDNLiP (ORCPT <rfc822;w@1wt.eu>);
	Mon, 14 Apr 2014 07:38:15 -0400
Received: from cam-admin0.cambridge.arm.com ([217.140.96.50]:35517 "EHLO
	cam-admin0.cambridge.arm.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1752488AbaDNLiN (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 14 Apr 2014 07:38:13 -0400
Date: Mon, 14 Apr 2014 12:37:18 +0100
From: Will Deacon <will.deacon@arm.com>
To: Liu Hua <sdu.liu@huawei.com>
Cc: "linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
        "horms@verge.net.au" <horms@verge.net.au>,
        "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
        "kexec@lists.infradead.org" <kexec@lists.infradead.org>,
        Stephen Warren <swarren@nvidia.com>,
        Vijaya Kumar K <vijay.kilari@gmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] ARM : kdump : add arch_crash_save_vmcoreinfo
Message-ID: <20140414113718.GD3530@arm.com>
References: <1395907240-13308-1-git-send-email-sdu.liu@huawei.com>
 <1395907240-13308-3-git-send-email-sdu.liu@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1395907240-13308-3-git-send-email-sdu.liu@huawei.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Mar 27, 2014 at 08:00:39AM +0000, Liu Hua wrote:
> For vmcore generated by LPAE enabled kernel, user space
> utility such as crash needs additional infomation to
> parse.
> 
> So this patch add arch_crash_save_vmcoreinfo as what PAE enabled
> i386 linux does.

Looks sensible to me:

  Reviewed-by: Will Deacon <will.deacon@arm.com>

Will

> Signed-off-by: Liu Hua <sdu.liu@huawei.com>
> To: Russell King <linux@arm.linux.org.uk>
> Cc: Stephen Warren <swarren@nvidia.com> 
> Cc: Will Deacon <will.deacon@arm.com>
> Cc: Vijaya Kumar K <vijay.kilari@gmail.com>
> Cc: <linux-arm-kernel@lists.infradead.org>
> Cc: <linux-kernel@vger.kernel.org>
> Cc: <kexec@lists.infradead.org>
> ---
>  arch/arm/kernel/machine_kexec.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm/kernel/machine_kexec.c b/arch/arm/kernel/machine_kexec.c
> index f0d180d..8cf0996 100644
> --- a/arch/arm/kernel/machine_kexec.c
> +++ b/arch/arm/kernel/machine_kexec.c
> @@ -184,3 +184,10 @@ void machine_kexec(struct kimage *image)
>  
>  	soft_restart(reboot_entry_phys);
>  }
> +
> +void arch_crash_save_vmcoreinfo(void)
> +{
> +#ifdef CONFIG_ARM_LPAE
> +	VMCOREINFO_CONFIG(ARM_LPAE);
> +#endif
> +}
> -- 
> 1.9.0
> 
>