From: Igor Mammedov <imammedo@redhat.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de,
mingo@redhat.com, hpa@zytor.com, x86@kernel.org, bp@suse.de,
paul.gortmaker@windriver.com, JBeulich@suse.com,
prarit@redhat.com, drjones@redhat.com, toshi.kani@hp.com,
riel@redhat.com, gong.chen@linux.intel.com, andi@firstfloor.org,
lenb@kernel.org, rjw@rjwysocki.net, linux-acpi@vger.kernel.org
Subject: Re: [PATCH v3 3/5] x86: fix list corruption on CPU hotplug
Date: Mon, 14 Apr 2014 11:56:00 +0200 [thread overview]
Message-ID: <20140414115600.0d5dbbb5@thinkpad> (raw)
In-Reply-To: <20140414091954.GB19771@gmail.com>
On Mon, 14 Apr 2014 11:19:54 +0200
Ingo Molnar <mingo@kernel.org> wrote:
>
> * Igor Mammedov <imammedo@redhat.com> wrote:
>
> > currently if AP wake up is failed, master CPU marks AP as not present
> > in do_boot_cpu() by calling set_cpu_present(cpu, false).
> > That leads to following list corruption on the next physical CPU
> > hotplug:
>
> Shouldn't this fix precede the main change to the smp bootup logic?
>
> Can this bug trigger with current upstream kernels?
That's not impossible, tests showed that with current kernel there will
be other problems due wild AP running around.
I'll reorder patch anyway.
>
> Thanks,
>
> Ingo
--
Regards,
Igor
next prev parent reply other threads:[~2014-04-14 9:56 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-10 17:14 [PATCH v3 0/5] x86: fix hang when AP bringup is too slow Igor Mammedov
2014-04-10 17:14 ` [PATCH v3 1/5] x86: initialize secondary CPU only if master CPU will wait for it Igor Mammedov
2014-04-14 9:16 ` Ingo Molnar
2014-04-14 9:52 ` Igor Mammedov
2014-04-14 10:03 ` Ingo Molnar
2014-04-14 10:21 ` Igor Mammedov
2014-04-14 12:50 ` Igor Mammedov
2014-04-14 14:51 ` Ingo Molnar
2014-04-14 15:03 ` Igor Mammedov
2014-04-10 17:14 ` [PATCH v3 2/5] x86: log error on secondary CPU wakeup failure at ERR level Igor Mammedov
2014-04-10 17:14 ` [PATCH v3 3/5] x86: fix list corruption on CPU hotplug Igor Mammedov
2014-04-14 9:19 ` Ingo Molnar
2014-04-14 9:56 ` Igor Mammedov [this message]
2014-04-14 10:04 ` Ingo Molnar
2014-04-14 10:23 ` Igor Mammedov
2014-04-14 10:34 ` Ingo Molnar
2014-04-14 10:48 ` Igor Mammedov
2014-04-14 10:56 ` Ingo Molnar
2014-04-10 17:14 ` [PATCH v3 4/5] x86: fix memory corruption in acpi_unmap_lsapic() Igor Mammedov
2014-04-14 9:20 ` Ingo Molnar
2014-04-10 17:14 ` [PATCH v3 5/5] acpi_processor: do not mark present at boot but not onlined CPU as onlined Igor Mammedov
2014-04-14 9:21 ` Ingo Molnar
2014-04-15 5:36 ` Rafael J. Wysocki
2014-04-15 5:43 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140414115600.0d5dbbb5@thinkpad \
--to=imammedo@redhat.com \
--cc=JBeulich@suse.com \
--cc=andi@firstfloor.org \
--cc=bp@suse.de \
--cc=drjones@redhat.com \
--cc=gong.chen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=paul.gortmaker@windriver.com \
--cc=prarit@redhat.com \
--cc=riel@redhat.com \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
--cc=toshi.kani@hp.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox