From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754804AbaDNPUz (ORCPT ); Mon, 14 Apr 2014 11:20:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:25854 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751589AbaDNPUv (ORCPT ); Mon, 14 Apr 2014 11:20:51 -0400 Date: Mon, 14 Apr 2014 17:20:25 +0200 From: Oleg Nesterov To: Andrew Morton , Peter Zijlstra Cc: Al Viro , David Woodhouse , Frederic Weisbecker , Geert Uytterhoeven , Ingo Molnar , Mathieu Desnoyers , Richard Weinberger , Steven Rostedt , Tejun Heo , linux-kernel@vger.kernel.org Subject: [PATCH RESEND 11/11] signals: change wait_for_helper() to use kernel_sigaction() Message-ID: <20140414152025.GA22032@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140414151929.GA21470@redhat.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Now that we have kernel_sigaction() we can change wait_for_helper() to use it and cleanups the code a bit. Signed-off-by: Oleg Nesterov --- kernel/kmod.c | 5 +---- 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/kernel/kmod.c b/kernel/kmod.c index 6b375af..c18c891 100644 --- a/kernel/kmod.c +++ b/kernel/kmod.c @@ -285,10 +285,7 @@ static int wait_for_helper(void *data) pid_t pid; /* If SIGCLD is ignored sys_wait4 won't populate the status. */ - spin_lock_irq(¤t->sighand->siglock); - current->sighand->action[SIGCHLD-1].sa.sa_handler = SIG_DFL; - spin_unlock_irq(¤t->sighand->siglock); - + kernel_sigaction(SIGCHLD, SIG_DFL); pid = kernel_thread(____call_usermodehelper, sub_info, SIGCHLD); if (pid < 0) { sub_info->retval = pid; -- 1.5.5.1