From: Will Deacon <will.deacon@arm.com>
To: Chanho Min <chanho.min@lge.com>
Cc: Catalin Marinas <Catalin.Marinas@arm.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] arm64:init: Move of_clk_init to time_init
Date: Mon, 14 Apr 2014 17:46:35 +0100 [thread overview]
Message-ID: <20140414164635.GD12916@arm.com> (raw)
In-Reply-To: <1397461133-12143-1-git-send-email-chanho.min@lge.com>
On Mon, Apr 14, 2014 at 08:38:53AM +0100, Chanho Min wrote:
> Clock providers should be initialized before clocksource_of_init.
> If not, Clock source initialization can be fail to get the clock.
>
> Signed-off-by: Chanho Min <chanho.min@lge.com>
Acked-by: Will Deacon <will.deacon@arm.com>
Will
> ---
> arch/arm64/kernel/setup.c | 1 -
> arch/arm64/kernel/time.c | 3 ++-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c
> index 720853f..93e7df89 100644
> --- a/arch/arm64/kernel/setup.c
> +++ b/arch/arm64/kernel/setup.c
> @@ -393,7 +393,6 @@ void __init setup_arch(char **cmdline_p)
>
> static int __init arm64_device_init(void)
> {
> - of_clk_init(NULL);
> of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL);
> return 0;
> }
> diff --git a/arch/arm64/kernel/time.c b/arch/arm64/kernel/time.c
> index 29c39d5..8799242 100644
> --- a/arch/arm64/kernel/time.c
> +++ b/arch/arm64/kernel/time.c
> @@ -33,6 +33,7 @@
> #include <linux/irq.h>
> #include <linux/delay.h>
> #include <linux/clocksource.h>
> +#include <linux/clk-provider.h>
>
> #include <clocksource/arm_arch_timer.h>
>
> @@ -64,7 +65,7 @@ EXPORT_SYMBOL(profile_pc);
> void __init time_init(void)
> {
> u32 arch_timer_rate;
> -
> + of_clk_init(NULL);
> clocksource_of_init();
>
> arch_timer_rate = arch_timer_get_rate();
> --
> 1.7.9.5
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
prev parent reply other threads:[~2014-04-14 16:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-14 7:38 [PATCH] arm64:init: Move of_clk_init to time_init Chanho Min
2014-04-14 16:46 ` Will Deacon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140414164635.GD12916@arm.com \
--to=will.deacon@arm.com \
--cc=Catalin.Marinas@arm.com \
--cc=ard.biesheuvel@linaro.org \
--cc=chanho.min@lge.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rob.herring@calxeda.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox