* [PATCH] arm64:init: Move of_clk_init to time_init
@ 2014-04-14 7:38 Chanho Min
2014-04-14 16:46 ` Will Deacon
0 siblings, 1 reply; 2+ messages in thread
From: Chanho Min @ 2014-04-14 7:38 UTC (permalink / raw)
To: Catalin Marinas
Cc: Will Deacon, Rob Herring, Ard Biesheuvel, linux-arm-kernel,
linux-kernel, Chanho Min
Clock providers should be initialized before clocksource_of_init.
If not, Clock source initialization can be fail to get the clock.
Signed-off-by: Chanho Min <chanho.min@lge.com>
---
arch/arm64/kernel/setup.c | 1 -
arch/arm64/kernel/time.c | 3 ++-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c
index 720853f..93e7df89 100644
--- a/arch/arm64/kernel/setup.c
+++ b/arch/arm64/kernel/setup.c
@@ -393,7 +393,6 @@ void __init setup_arch(char **cmdline_p)
static int __init arm64_device_init(void)
{
- of_clk_init(NULL);
of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL);
return 0;
}
diff --git a/arch/arm64/kernel/time.c b/arch/arm64/kernel/time.c
index 29c39d5..8799242 100644
--- a/arch/arm64/kernel/time.c
+++ b/arch/arm64/kernel/time.c
@@ -33,6 +33,7 @@
#include <linux/irq.h>
#include <linux/delay.h>
#include <linux/clocksource.h>
+#include <linux/clk-provider.h>
#include <clocksource/arm_arch_timer.h>
@@ -64,7 +65,7 @@ EXPORT_SYMBOL(profile_pc);
void __init time_init(void)
{
u32 arch_timer_rate;
-
+ of_clk_init(NULL);
clocksource_of_init();
arch_timer_rate = arch_timer_get_rate();
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] arm64:init: Move of_clk_init to time_init
2014-04-14 7:38 [PATCH] arm64:init: Move of_clk_init to time_init Chanho Min
@ 2014-04-14 16:46 ` Will Deacon
0 siblings, 0 replies; 2+ messages in thread
From: Will Deacon @ 2014-04-14 16:46 UTC (permalink / raw)
To: Chanho Min
Cc: Catalin Marinas, Ard Biesheuvel, linux-kernel@vger.kernel.org,
rob.herring@calxeda.com, linux-arm-kernel@lists.infradead.org
On Mon, Apr 14, 2014 at 08:38:53AM +0100, Chanho Min wrote:
> Clock providers should be initialized before clocksource_of_init.
> If not, Clock source initialization can be fail to get the clock.
>
> Signed-off-by: Chanho Min <chanho.min@lge.com>
Acked-by: Will Deacon <will.deacon@arm.com>
Will
> ---
> arch/arm64/kernel/setup.c | 1 -
> arch/arm64/kernel/time.c | 3 ++-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c
> index 720853f..93e7df89 100644
> --- a/arch/arm64/kernel/setup.c
> +++ b/arch/arm64/kernel/setup.c
> @@ -393,7 +393,6 @@ void __init setup_arch(char **cmdline_p)
>
> static int __init arm64_device_init(void)
> {
> - of_clk_init(NULL);
> of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL);
> return 0;
> }
> diff --git a/arch/arm64/kernel/time.c b/arch/arm64/kernel/time.c
> index 29c39d5..8799242 100644
> --- a/arch/arm64/kernel/time.c
> +++ b/arch/arm64/kernel/time.c
> @@ -33,6 +33,7 @@
> #include <linux/irq.h>
> #include <linux/delay.h>
> #include <linux/clocksource.h>
> +#include <linux/clk-provider.h>
>
> #include <clocksource/arm_arch_timer.h>
>
> @@ -64,7 +65,7 @@ EXPORT_SYMBOL(profile_pc);
> void __init time_init(void)
> {
> u32 arch_timer_rate;
> -
> + of_clk_init(NULL);
> clocksource_of_init();
>
> arch_timer_rate = arch_timer_get_rate();
> --
> 1.7.9.5
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-04-14 16:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-14 7:38 [PATCH] arm64:init: Move of_clk_init to time_init Chanho Min
2014-04-14 16:46 ` Will Deacon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox