From: Mark Brown <broonie@kernel.org>
To: Axel Lin <axel.lin@ingics.com>
Cc: Chris Ball <chris@printf.net>,
Liam Girdwood <lgirdwood@gmail.com>, Balaji T K <balajitk@ti.com>,
Florian Vaussard <florian.vaussard@epfl.ch>,
Stefan Roese <sr@denx.de>,
linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org
Subject: Re: [PATCH v2 1/2] regulator: pbias: Fix is_enabled callback implementation
Date: Mon, 14 Apr 2014 22:16:44 +0100 [thread overview]
Message-ID: <20140414211644.GG12304@sirena.org.uk> (raw)
In-Reply-To: <1394250929.3892.1.camel@phoenix>
[-- Attachment #1: Type: text/plain, Size: 441 bytes --]
On Sat, Mar 08, 2014 at 11:55:29AM +0800, Axel Lin wrote:
> The is_enabled implementation is wrong in some cases:
> e.g. for pbias_mmc_omap5: enable_mask is : BIT(27) | BIT(25) | BIT(26)
> However, pbias_regulator_enable() only sets BIT(27) | BIT(26) bits.
> So is_enabled callback will always return false in this case.
> Fix the logic to compare the register value with info->enable rather than
> info->enable_mask.
Applied both, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-04-14 21:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-08 3:55 [PATCH v2 1/2] regulator: pbias: Fix is_enabled callback implementation Axel Lin
2014-03-08 3:56 ` [PATCH v2 2/2] regulator: pbias: Convert to use regmap helper functions Axel Lin
2014-04-02 0:26 ` [PATCH v2 1/2] regulator: pbias: Fix is_enabled callback implementation Axel Lin
2014-04-09 9:50 ` Axel Lin
2014-04-10 17:30 ` Mark Brown
2014-04-14 21:16 ` Mark Brown [this message]
2014-04-15 15:14 ` Axel Lin
2014-04-18 17:27 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140414211644.GG12304@sirena.org.uk \
--to=broonie@kernel.org \
--cc=axel.lin@ingics.com \
--cc=balajitk@ti.com \
--cc=chris@printf.net \
--cc=florian.vaussard@epfl.ch \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=sr@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox