From: Will Deacon <will.deacon@arm.com>
To: Pranith Kumar <bobby.prani@gmail.com>
Cc: Catalin Marinas <Catalin.Marinas@arm.com>,
Joe Perches <joe@perches.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 1/1] prefetch result in 64 bit atomic ops
Date: Tue, 15 Apr 2014 08:52:20 +0100 [thread overview]
Message-ID: <20140415075220.GC17408@arm.com> (raw)
In-Reply-To: <534C2CC2.9050706@gmail.com>
Hi Pranith,
On Mon, Apr 14, 2014 at 07:45:22PM +0100, Pranith Kumar wrote:
> Please disregard previous patches. This is the correct one.
>
> prefetch destination as is being done in ARM32 atomic ops
Whilst this looks like a potentially sensible optimisation (based on the
results I saw on AArch32), I don't think we can take this patch without some
benchmarks on real silicon. The interaction between the half-barrier atomic
instructions and prfm isn't immediately obvious to me, and we should also
consider looking at streaming preload vs the l1keep option.
Did you write this patch as a basic port of the arch/arm/ patches I wrote,
or was it based on performance figures from real hardware?
Will
next prev parent reply other threads:[~2014-04-15 7:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-14 18:45 [RFC PATCH 1/1] prefetch result in 64 bit atomic ops Pranith Kumar
2014-04-15 7:52 ` Will Deacon [this message]
2014-04-15 8:33 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140415075220.GC17408@arm.com \
--to=will.deacon@arm.com \
--cc=Catalin.Marinas@arm.com \
--cc=bobby.prani@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox