Re: [patch 2/4] mm: Dont forget to set softdirty on file mapped fault

Andrew Morton
2014-04-14T22:28:02Z

On Mon, 24 Mar 2014 16:28:40 +0400 Cyrill Gorcunov <gorcunov@openvz.org> wrote:

> Otherwise we may not notice that pte was softdirty.
>
> --- linux-2.6.git.orig/mm/memory.c
> +++ linux-2.6.git/mm/memory.c
> @@ -3422,7 +3422,7 @@ static int __do_fault(struct mm_struct *
> if (flags & FAULT_FLAG_WRITE)
> entry = maybe_mkwrite(pte_mkdirty(entry), vma);
> else if (pte_file(orig_pte) && pte_file_soft_dirty(orig_pte))
> - pte_mksoft_dirty(entry);
> + entry = pte_mksoft_dirty(entry);
> if (anon) {
> inc_mm_counter_fast(mm, MM_ANONPAGES);
> page_add_new_anon_rmap(page, vma, address);

This will need to be redone for current kernels, please. New patch, new
title, new changelog, retest.