Re: [PATCH 1/2] workqueue: fix bugs in wq_update_unbound_numa() failure path

Tejun Heo
2014-04-16T17:30:38Z

On Wed, Apr 16, 2014 at 02:32:29PM +0900, Daeseok Youn wrote:
>
> wq_update_unbound_numa() failure path has the following two bugs.
> - alloc_unbound_pwq() is called without holding wq->mutex;
> however, if the allocation fails, it jumps to out_unlock
> which tries to unlock wq->mutex.
>
> - The function should switch to dfl_pwq on failure
> but didn't do so after alloc_unbound_pwq() failure.
>
> Fix it by regrabbing wq->mutex and jumping to use_dfl_pwq on
> alloc_unbound_pwq() failure.
>
> Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>

Applied to wq/for-3.15-fixes.

Thanks.

--
tejun