From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755063AbaDPJP7 (ORCPT ); Wed, 16 Apr 2014 05:15:59 -0400 Received: from mail-wi0-f180.google.com ([209.85.212.180]:45082 "EHLO mail-wi0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751105AbaDPJPg (ORCPT ); Wed, 16 Apr 2014 05:15:36 -0400 Date: Wed, 16 Apr 2014 10:15:31 +0100 From: Lee Jones To: Fabio Estevam Cc: sameo@linux.intel.com, linux@arm.linux.org.uk, linux-kernel@vger.kernel.org, Fabio Estevam Subject: Re: [PATCH v2] mfd: mc13xxx-core: Initialize the lock prior to using it Message-ID: <20140416091531.GD4754@lee--X1> References: <1397602574-28025-1-git-send-email-festevam@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1397602574-28025-1-git-send-email-festevam@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > From: Fabio Estevam > > After request_threaded_irq() is called there is a chance that an interrupt > may occur before the 'mc13xxx->lock' is initialized, which will trigger a kernel > oops. > > In order to prevent that, move the initialization of 'mc13xxx->lock' prior to > requesting the interrupts. > > Suggested-by: Russell King > Signed-off-by: Fabio Estevam > --- > Changes since v1: > - Changed kernel warning --> kernel oops to better describe the problem > - Added Russell's Ack No you didn't. ;) Applied with Russell's Ack. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog