From: Greg KH <gregkh@linuxfoundation.org>
To: Paul McQuade <paulmcquad@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging:Line6:usbdefs.h parenthesis for Marcos
Date: Wed, 16 Apr 2014 20:28:37 -0700 [thread overview]
Message-ID: <20140417032837.GA3380@kroah.com> (raw)
In-Reply-To: <1396973486-30547-1-git-send-email-paulmcquad@gmail.com>
On Tue, Apr 08, 2014 at 05:11:26PM +0100, Paul McQuade wrote:
> ERROR: Macros with complex values should be enclosed in parenthesis
>
> Signed-off-by: Paul McQuade <paulmcquad@gmail.com>
> ---
> drivers/staging/line6/usbdefs.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/line6/usbdefs.h b/drivers/staging/line6/usbdefs.h
> index 2d1cc47..48958b5 100644
> --- a/drivers/staging/line6/usbdefs.h
> +++ b/drivers/staging/line6/usbdefs.h
> @@ -40,7 +40,7 @@
> #define LINE6_DEVID_TONEPORT_UX2 0x4142
> #define LINE6_DEVID_VARIAX 0x534d
>
> -#define LINE6_BIT(x) LINE6_BIT_ ## x = 1 << LINE6_INDEX_ ## x
> +#define LINE6_BIT(x) (LINE6_BIT_ ## x = 1 << LINE6_INDEX_ ## x)
I love this one, it gets people all the time who don't actually test
their changes...
Hint, it breaks the build, which isn't nice at all. Please ALWAYS test
build your kernel changes, don't break other people's build boxes...
greg k-h
prev parent reply other threads:[~2014-04-17 3:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-08 16:11 [PATCH] Staging:Line6:usbdefs.h parenthesis for Marcos Paul McQuade
2014-04-17 3:28 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140417032837.GA3380@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmcquad@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox