* [PATCH] Staging:Line6:usbdefs.h parenthesis for Marcos
@ 2014-04-08 16:11 Paul McQuade
2014-04-17 3:28 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Paul McQuade @ 2014-04-08 16:11 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel
ERROR: Macros with complex values should be enclosed in parenthesis
Signed-off-by: Paul McQuade <paulmcquad@gmail.com>
---
drivers/staging/line6/usbdefs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/line6/usbdefs.h b/drivers/staging/line6/usbdefs.h
index 2d1cc47..48958b5 100644
--- a/drivers/staging/line6/usbdefs.h
+++ b/drivers/staging/line6/usbdefs.h
@@ -40,7 +40,7 @@
#define LINE6_DEVID_TONEPORT_UX2 0x4142
#define LINE6_DEVID_VARIAX 0x534d
-#define LINE6_BIT(x) LINE6_BIT_ ## x = 1 << LINE6_INDEX_ ## x
+#define LINE6_BIT(x) (LINE6_BIT_ ## x = 1 << LINE6_INDEX_ ## x)
enum {
LINE6_INDEX_BASSPODXT,
--
1.8.3.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] Staging:Line6:usbdefs.h parenthesis for Marcos
2014-04-08 16:11 [PATCH] Staging:Line6:usbdefs.h parenthesis for Marcos Paul McQuade
@ 2014-04-17 3:28 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2014-04-17 3:28 UTC (permalink / raw)
To: Paul McQuade; +Cc: devel, linux-kernel
On Tue, Apr 08, 2014 at 05:11:26PM +0100, Paul McQuade wrote:
> ERROR: Macros with complex values should be enclosed in parenthesis
>
> Signed-off-by: Paul McQuade <paulmcquad@gmail.com>
> ---
> drivers/staging/line6/usbdefs.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/line6/usbdefs.h b/drivers/staging/line6/usbdefs.h
> index 2d1cc47..48958b5 100644
> --- a/drivers/staging/line6/usbdefs.h
> +++ b/drivers/staging/line6/usbdefs.h
> @@ -40,7 +40,7 @@
> #define LINE6_DEVID_TONEPORT_UX2 0x4142
> #define LINE6_DEVID_VARIAX 0x534d
>
> -#define LINE6_BIT(x) LINE6_BIT_ ## x = 1 << LINE6_INDEX_ ## x
> +#define LINE6_BIT(x) (LINE6_BIT_ ## x = 1 << LINE6_INDEX_ ## x)
I love this one, it gets people all the time who don't actually test
their changes...
Hint, it breaks the build, which isn't nice at all. Please ALWAYS test
build your kernel changes, don't break other people's build boxes...
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-04-17 3:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-08 16:11 [PATCH] Staging:Line6:usbdefs.h parenthesis for Marcos Paul McQuade
2014-04-17 3:28 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox