Re: [PATCH 2/6] mfd: stmpe: add optional regulators

[Lee Jones <lee.jones@linaro.org>]

> The STMPE has VCC and VIO supply lines, and sometimes (as on
> Ux500) this comes from a software-controlled regulator. Make
> it possible to supply the STMPE with power from these
> regulators.
> 
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
>  drivers/mfd/stmpe.c       | 18 ++++++++++++++++++
>  include/linux/mfd/stmpe.h |  5 +++++
>  2 files changed, 23 insertions(+)

[...]

> +	stmpe->vcc = devm_regulator_get_optional(ci->dev, "vcc");
> +	if (!IS_ERR(stmpe->vcc)) {
> +		ret = regulator_enable(stmpe->vcc);
> +		if (ret)
> +			dev_warn(ci->dev, "failed to enable VCC supply\n");
> +	}
> +	stmpe->vio = devm_regulator_get_optional(ci->dev, "vio");
> +	if (!IS_ERR(stmpe->vio)) {
> +		ret = regulator_enable(stmpe->vio);
> +		if (ret)
> +			dev_warn(ci->dev, "failed to enable VIO supply\n");
> +	}

[...]

>  int stmpe_remove(struct stmpe *stmpe)
>  {
> +	if (!IS_ERR(stmpe->vio))
> +		regulator_disable(stmpe->vio);
> +	if (!IS_ERR(stmpe->vcc))
> +		regulator_disable(stmpe->vcc);
> +

Genuine question:
  Doesn't the regulator core take care of this for you on removal?

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog