From: Marek Vasut <marex@denx.de>
To: Jianyu Zhan <nasa4836@gmail.com>
Cc: herbert@gondor.apana.org.au, davem@davemloft.net,
tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
x86@kernel.org, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] crypto: sha{256,512}_ssse3 - remove asmlinkage from static functions
Date: Thu, 17 Apr 2014 17:28:41 +0200 [thread overview]
Message-ID: <201404171728.41994.marex@denx.de> (raw)
In-Reply-To: <1397665190-12491-1-git-send-email-nasa4836@gmail.com>
On Wednesday, April 16, 2014 at 06:19:50 PM, Jianyu Zhan wrote:
> Commit 128ea04a9885("lto: Make asmlinkage __visible") restricts
> asmlinkage to externally_visible, this causes compilation warnings:
>
> arch/x86/crypto/sha256_ssse3_glue.c:56:1:
> warning: ‘externally_visible’ attribute have effect only on public
> objects [-Wattributes]
>
> static asmlinkage void (*sha256_transform_asm)(const char *, u32 *,
> u64); ^
>
> arch/x86/crypto/sha512_ssse3_glue.c:55:1:
> warning: ‘externally_visible’ attribute have effect only on public
> objects [-Wattributes] static asmlinkage void
> (*sha512_transform_asm)(const char *, u64 *, ^
>
> Drop asmlinkage here to avoid such warnings.
>
> Also see Commit 8783dd3a37a5853689e1("irqchip: Remove asmlinkage from
> static functions")
>
> Signed-off-by: Jianyu Zhan <nasa4836@gmail.com>
Makes sense, please add my humble
Reviewed-by: Marek Vasut <marex@denx.de>
Best regards,
Marek Vasut
next prev parent reply other threads:[~2014-04-17 15:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-16 16:19 [PATCH] crypto: sha{256,512}_ssse3 - remove asmlinkage from static functions Jianyu Zhan
2014-04-17 15:28 ` Marek Vasut [this message]
2014-04-18 4:49 ` H. Peter Anvin
2014-04-18 4:58 ` Herbert Xu
2014-04-18 5:01 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201404171728.41994.marex@denx.de \
--to=marex@denx.de \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=hpa@zytor.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=nasa4836@gmail.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox