From: "Theodore Ts'o" <tytso@mit.edu>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: an infinite loop in ext4 in 3.14
Date: Thu, 17 Apr 2014 17:16:27 -0400 [thread overview]
Message-ID: <20140417211627.GC4979@thunk.org> (raw)
In-Reply-To: <alpine.LRH.2.02.1404171510330.22570@file01.intranet.prod.int.rdu2.redhat.com>
On Thu, Apr 17, 2014 at 03:23:13PM -0400, Mikulas Patocka wrote:
>
> I hit a bug in ext4 - jbd2 was stuck in an infinite loop when remounting
> the root filesystem read-only during shutdown.
Is this at all repeatable? I suspect what happened is that we're not
checking the error return from jbd2_log_do_checkpoint(), and if it ran
into an error doing the jbd2_log_do_checkpoint --- for example, if it
wasn't able to write to the journal --- say, because __wait_cp_io()
returned -EIO, we might be spinning in the while loop in jbd2_journal_flush:
> while (!err && journal->j_checkpoint_transactions != NULL) {
(as you suspected).
I can add some error checking, but it would be interesting to know if
you can easily reproduce the problem so we can confirm if that's what
was really going on.
Regards,
- Ted
next prev parent reply other threads:[~2014-04-17 21:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-17 19:23 an infinite loop in ext4 in 3.14 Mikulas Patocka
2014-04-17 21:16 ` Theodore Ts'o [this message]
2014-04-17 22:36 ` Mikulas Patocka
2014-04-19 20:33 ` Mikulas Patocka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140417211627.GC4979@thunk.org \
--to=tytso@mit.edu \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpatocka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox