From: Ingo Molnar <mingo@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: linux-kernel@vger.kernel.org,
Corey Ashford <cjashfor@linux.vnet.ibm.com>,
David Ahern <dsahern@gmail.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Namhyung Kim <namhyung@kernel.org>,
Paul Mackerras <paulus@samba.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Jean Pihet <jean.pihet@linaro.org>
Subject: Re: [PATCH 0/3] perf tools: Speedup DWARF unwind
Date: Fri, 18 Apr 2014 09:55:25 +0200 [thread overview]
Message-ID: <20140418075525.GA14243@gmail.com> (raw)
In-Reply-To: <20140418075148.GA13793@gmail.com>
* Ingo Molnar <mingo@kernel.org> wrote:
>
> * Jiri Olsa <jolsa@redhat.com> wrote:
>
> > hi,
> > trying to speedup DWARF unwind report code by factoring
> > related code:
> > - caching sample's registers access
> > - keep dso data file descriptor open for the
> > life of the dso object
> > - replace dso cache code by mapping dso data file
> > directly for the life of the dso object
> >
> > The speedup is mainly for libunwind unwind. The libdw will benefit
> > mainly from cached registers access, because it handles dso data
> > accesses by itself.. and anyway it's still faster ;-).
>
> Just curious: do you have any numbers about how much faster it got in
> practice?
Oh, the numbers are all in the changelogs, never mind!
So in your test workload it went from 54.6 seconds to 36.7, a 48%
speedup :-)
Thanks,
Ingo
next prev parent reply other threads:[~2014-04-18 7:55 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-17 17:39 [PATCH 0/3] perf tools: Speedup DWARF unwind Jiri Olsa
2014-04-17 17:39 ` [PATCH 1/3] perf tools: Cache register accesses for unwind processing Jiri Olsa
2014-04-27 14:29 ` Namhyung Kim
2014-04-28 9:48 ` Jiri Olsa
2014-04-28 13:02 ` Namhyung Kim
2014-04-28 13:24 ` Jiri Olsa
2014-04-29 0:36 ` Namhyung Kim
2014-04-30 12:12 ` Jiri Olsa
2014-04-28 10:39 ` Christian Borntraeger
2014-04-28 11:00 ` Jiri Olsa
2014-04-17 17:39 ` [PATCH 2/3] perf tools: Cache dso data file descriptor Jiri Olsa
2014-04-27 14:36 ` Namhyung Kim
2014-04-28 10:01 ` Jiri Olsa
2014-04-28 13:16 ` Namhyung Kim
2014-04-28 13:34 ` Jiri Olsa
2014-04-28 14:57 ` David Ahern
2014-04-29 0:41 ` Namhyung Kim
2014-05-07 19:01 ` Ingo Molnar
2014-04-17 17:39 ` [PATCH 3/3] perf tools: Replace dso data cache with mapped data Jiri Olsa
2014-04-18 7:51 ` [PATCH 0/3] perf tools: Speedup DWARF unwind Ingo Molnar
2014-04-18 7:55 ` Ingo Molnar [this message]
2014-04-18 9:35 ` Jiri Olsa
2014-04-23 20:16 ` Jiri Olsa
2014-04-25 13:08 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140418075525.GA14243@gmail.com \
--to=mingo@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=cjashfor@linux.vnet.ibm.com \
--cc=dsahern@gmail.com \
--cc=fweisbec@gmail.com \
--cc=jean.pihet@linaro.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).