From: Ingo Molnar <mingo@kernel.org>
To: Borislav Petkov <bp@alien8.de>
Cc: Owen Kibel <qmewlo@gmail.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Josh Boyer <jwboyer@fedoraproject.org>,
"Luck, Tony" <tony.luck@intel.com>,
Peter Zijlstra <peterz@infradead.org>,
"hpa@zytor.com" <hpa@zytor.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"atodorov@redhat.com" <atodorov@redhat.com>,
"gong.chen@linux.intel.com" <gong.chen@linux.intel.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"linux-tip-commits@vger.kernel.org"
<linux-tip-commits@vger.kernel.org>
Subject: Re: [tip:x86/urgent] x86/mce: Fix CMCI preemption bugs
Date: Fri, 18 Apr 2014 10:07:16 +0200 [thread overview]
Message-ID: <20140418080716.GA14280@gmail.com> (raw)
In-Reply-To: <20140417222028.GD27852@pd.tnic>
* Borislav Petkov <bp@alien8.de> wrote:
> On Thu, Apr 17, 2014 at 11:30:12PM +0200, Borislav Petkov wrote:
> > This is most likely unrelated and is caused by the preemption checks
> > added to __this_cpu_* in 188a81409ff7. If you'd like to debug this
> > further, please send a full dmesg:
> >
> > dmesg > dmesg.log
> >
> > Privately is fine too.
>
> Ok, thanks for the dmesg. Replying to the thread with everybody:
>
> The splat Owen is seeing is the same as this one at the beginning of
> this thread here:
>
> http://lkml.kernel.org/r/8761m7lm3j.fsf@canonical.com
>
> which has a viable fix. Btw, those two splats happen on HP notebooks.
>
> Ok, good, I think we're all solved. Phew :-)
>
> Thanks to all for their help.
Okay, so AFAICS the fix in x86/urgent isn't wrong functionally, it's
just that the changelog incorrectly claims the raw-spinlock use is a
bug causing a problem here.
Still that raw spinlock is bogus and might be hiding other problems,
so we can keep the x86/urgent change (ea431643d6c3) as-is and I'll get
it to Linus later today ...
Thanks,
Ingo
next prev parent reply other threads:[~2014-04-18 8:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-17 9:57 [tip:x86/urgent] x86/mce: Fix CMCI preemption bugs tip-bot for Ingo Molnar
2014-04-17 10:09 ` Peter Zijlstra
2014-04-17 10:24 ` Borislav Petkov
2014-04-17 14:03 ` Luck, Tony
2014-04-17 15:26 ` Borislav Petkov
2014-04-17 16:54 ` Josh Boyer
2014-04-17 19:23 ` Borislav Petkov
2014-04-17 19:25 ` Linus Torvalds
2014-04-17 19:42 ` Borislav Petkov
2014-04-17 20:58 ` Borislav Petkov
[not found] ` <CAK7FoDt6tnknX7cioe7=2svVksyAyLUtoZX_oprzJNxoHZEpdw@mail.gmail.com>
2014-04-17 21:30 ` Borislav Petkov
2014-04-17 22:20 ` Borislav Petkov
2014-04-18 8:07 ` Ingo Molnar [this message]
2014-04-18 9:22 ` Borislav Petkov
2014-04-25 8:47 ` Chen, Gong
2014-04-25 13:15 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140418080716.GA14280@gmail.com \
--to=mingo@kernel.org \
--cc=atodorov@redhat.com \
--cc=bp@alien8.de \
--cc=gong.chen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jwboyer@fedoraproject.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=qmewlo@gmail.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).