* [PATCH v2 0/2] staging: panel: fix sparse warnings.
@ 2014-04-18 16:09 Bastien Armand
2014-04-20 6:24 ` Willy Tarreau
0 siblings, 1 reply; 2+ messages in thread
From: Bastien Armand @ 2014-04-18 16:09 UTC (permalink / raw)
To: Willy Tarreau, Greg Kroah-Hartman, Monam Agarwal, Jake Champlin,
Arnd Bergmann
Cc: devel, linux-kernel
This serie of two patch fix the following sparse warnings in panel.c :
panel.c:1235:26: warning: incorrect type in argument 1 (different address spaces)
panel.c:1235:26: expected void const volatile [noderef] <asn:1>*<noident>
panel.c:1235:26: got char const *tmp
panel.c:1353:20: warning: incorrect type in initializer (incompatible argument 2 (different address spaces))
panel.c:1353:20: expected int ( *write )( ... )
panel.c:1353:20: got int ( static [toplevel] *<noident> )( ... )
panel.c:1591:17: warning: incorrect type in argument 1 (different address spaces)
panel.c:1591:17: expected void const volatile [noderef] <asn:1>*<noident>
panel.c:1591:17: got char *tmp
panel.c:1620:20: warning: incorrect type in initializer (incompatible argument 2 (different address spaces))
panel.c:1620:20: expected int ( *read )( ... )
panel.c:1620:20: got int ( static [toplevel] *<noident> )( ... )
Changes since v1 :
- splitted patch in two
Bastien Armand (2):
staging: panel: fix sparse warnings in keypad_read
staging: panel: fix sparse warnings in lcd_write
drivers/staging/panel/panel.c | 209 ++++++++++++++++++++++-------------------
1 file changed, 111 insertions(+), 98 deletions(-)
--
1.7.10.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2 0/2] staging: panel: fix sparse warnings.
2014-04-18 16:09 [PATCH v2 0/2] staging: panel: fix sparse warnings Bastien Armand
@ 2014-04-20 6:24 ` Willy Tarreau
0 siblings, 0 replies; 2+ messages in thread
From: Willy Tarreau @ 2014-04-20 6:24 UTC (permalink / raw)
To: Bastien Armand
Cc: Greg Kroah-Hartman, Monam Agarwal, Jake Champlin, Arnd Bergmann,
devel, linux-kernel
Hi Bastien,
On Fri, Apr 18, 2014 at 06:09:18PM +0200, Bastien Armand wrote:
> This serie of two patch fix the following sparse warnings in panel.c :
> panel.c:1235:26: warning: incorrect type in argument 1 (different address spaces)
> panel.c:1235:26: expected void const volatile [noderef] <asn:1>*<noident>
> panel.c:1235:26: got char const *tmp
> panel.c:1353:20: warning: incorrect type in initializer (incompatible argument 2 (different address spaces))
> panel.c:1353:20: expected int ( *write )( ... )
> panel.c:1353:20: got int ( static [toplevel] *<noident> )( ... )
> panel.c:1591:17: warning: incorrect type in argument 1 (different address spaces)
> panel.c:1591:17: expected void const volatile [noderef] <asn:1>*<noident>
> panel.c:1591:17: got char *tmp
> panel.c:1620:20: warning: incorrect type in initializer (incompatible argument 2 (different address spaces))
> panel.c:1620:20: expected int ( *read )( ... )
> panel.c:1620:20: got int ( static [toplevel] *<noident> )( ... )
>
> Changes since v1 :
> - splitted patch in two
>
> Bastien Armand (2):
> staging: panel: fix sparse warnings in keypad_read
> staging: panel: fix sparse warnings in lcd_write
Just reviewed them both and I'm fine with these patches. You can
add my :
Acked-by: Willy Tarreau <w@1wt.eu>
Willy
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-04-20 6:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-18 16:09 [PATCH v2 0/2] staging: panel: fix sparse warnings Bastien Armand
2014-04-20 6:24 ` Willy Tarreau
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox