From: Andi Kleen <andi@firstfloor.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: "Yan, Zheng" <zheng.z.yan@intel.com>,
linux-kernel@vger.kernel.org, a.p.zijlstra@chello.nl,
acme@infradead.org, eranian@google.com, andi@firstfloor.org
Subject: Re: [PATCH v2 4/4] perf/x86/uncore: modularize Intel uncore driver
Date: Fri, 18 Apr 2014 18:49:14 +0200 [thread overview]
Message-ID: <20140418164914.GL22728@two.firstfloor.org> (raw)
In-Reply-To: <20140418105354.GA29167@gmail.com>
> So I'm not willing to apply this patch until the documentation of
> perf_event_intel_uncore.c is improved. Right now the file starts
> without a single comment (!). Just lines after lines of code, without
> any explanation what it does, what its scope is, etc.
>
> How should even a knowledgable user know about what it's all about?
While I agree with you that the lack of documentation is bad,
I want to point out that the rest of perf (except for some recent
code from Stephane) doesn't have any such file comments and useful
Kconfig descriptions either.
It seems unfair and inconsistent to require contributors to follow rules that
is not followed by the original code.
-Andi
next prev parent reply other threads:[~2014-04-18 16:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-20 6:03 [PATCH v2 4/4] perf/x86/uncore: modularize Intel uncore driver Yan, Zheng
2014-03-20 8:27 ` Peter Zijlstra
2014-04-18 10:53 ` Ingo Molnar
2014-04-18 16:49 ` Andi Kleen [this message]
2014-04-21 2:18 ` Yan, Zheng
2014-04-22 11:35 ` Ingo Molnar
2014-04-23 14:55 ` Stephane Eranian
2014-04-24 8:14 ` Ingo Molnar
2014-04-24 10:25 ` Yan, Zheng
2014-04-24 10:36 ` Stephane Eranian
2014-04-24 10:37 ` Yan, Zheng
2014-04-24 11:27 ` Peter Zijlstra
2014-04-25 13:17 ` Yan, Zheng
2014-04-25 13:55 ` Peter Zijlstra
2014-04-25 14:06 ` Yan, Zheng
2014-04-25 14:35 ` Peter Zijlstra
2014-04-25 14:44 ` Yan, Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140418164914.GL22728@two.firstfloor.org \
--to=andi@firstfloor.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@infradead.org \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=zheng.z.yan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox