* [PATCH] staging: rtl8192u: r8192U_wx: Fix sparse warnings
@ 2014-03-21 14:07 Matei Oprea
2014-04-18 23:02 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Matei Oprea @ 2014-03-21 14:07 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel, Matei Oprea, ROSEdu Kernel Community
Fix sparse "should be static" warnings. Those structures are
only referenced in file scope so they can be marked as static.
Signed-off-by: Matei Oprea <eu@opreamatei.ro>
Cc: ROSEdu Kernel Community <firefly@lists.rosedu.org>
---
drivers/staging/rtl8192u/r8192U_wx.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_wx.c b/drivers/staging/rtl8192u/r8192U_wx.c
index c70af01..1a3e80d 100644
--- a/drivers/staging/rtl8192u/r8192U_wx.c
+++ b/drivers/staging/rtl8192u/r8192U_wx.c
@@ -24,7 +24,7 @@
#include "dot11d.h"
#define RATE_COUNT 12
-u32 rtl8180_rates[] = {1000000,2000000,5500000,11000000,
+static u32 rtl8180_rates[] = {1000000,2000000,5500000,11000000,
6000000,9000000,12000000,18000000,24000000,36000000,48000000,54000000};
@@ -979,7 +979,7 @@ static iw_handler r8192_private_handler[] = {
};
//#if WIRELESS_EXT >= 17
-struct iw_statistics *r8192_get_wireless_stats(struct net_device *dev)
+static struct iw_statistics *r8192_get_wireless_stats(struct net_device *dev)
{
struct r8192_priv *priv = ieee80211_priv(dev);
struct ieee80211_device *ieee = priv->ieee80211;
@@ -1010,7 +1010,7 @@ struct iw_statistics *r8192_get_wireless_stats(struct net_device *dev)
//#endif
-struct iw_handler_def r8192_wx_handlers_def={
+static struct iw_handler_def r8192_wx_handlers_def={
.standard = r8192_wx_handlers,
.num_standard = ARRAY_SIZE(r8192_wx_handlers),
.private = r8192_private_handler,
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: rtl8192u: r8192U_wx: Fix sparse warnings
2014-03-21 14:07 [PATCH] staging: rtl8192u: r8192U_wx: Fix sparse warnings Matei Oprea
@ 2014-04-18 23:02 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2014-04-18 23:02 UTC (permalink / raw)
To: Matei Oprea; +Cc: devel, ROSEdu Kernel Community, linux-kernel
On Fri, Mar 21, 2014 at 04:07:49PM +0200, Matei Oprea wrote:
> Fix sparse "should be static" warnings. Those structures are
> only referenced in file scope so they can be marked as static.
>
> Signed-off-by: Matei Oprea <eu@opreamatei.ro>
> Cc: ROSEdu Kernel Community <firefly@lists.rosedu.org>
> ---
> drivers/staging/rtl8192u/r8192U_wx.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
This patch breaks the build, how did you test it?
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-04-18 23:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-21 14:07 [PATCH] staging: rtl8192u: r8192U_wx: Fix sparse warnings Matei Oprea
2014-04-18 23:02 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox