Re: [PATCHv3 08/14] HSI: Introduce OMAP SSI driver

[Pavel Machek <pavel@ucw.cz>]

Hi!

> Add OMAP SSI driver to the HSI subsystem.
> 
> The Synchronous Serial Interface (SSI) is a legacy version
> of HSI. As in the case of HSI, it is mainly used to connect
> Application engines (APE) with cellular modem engines (CMT)
> in cellular handsets.
> 
> It provides a multichannel, full-duplex, multi-core communication
> with no reference clock. The OMAP SSI block is capable of reaching
> speeds of 110 Mbit/s.
> 
> Signed-off-by: Carlos Chinea <carlos.chinea@nokia.com>
> Signed-off-by: Sebastian Reichel <sre@kernel.org>

> +	bool			wktest:1; /* FIXME: HACK to be removed */
> +	bool			wkin_cken:1; /* Workaround */

There is more thanone FIXME in the code. It may be better to fix after
merge...


> +DEFINE_SIMPLE_ATTRIBUTE(ssi_sst_div_fops, ssi_div_get, ssi_div_set, "%llu\n");
> +
> +static int __init ssi_debug_add_port(struct omap_ssi_port *omap_port,
> +							struct dentry *dir)
> +{

A little strange indentation. Is it intentional?

> +	if (IS_ERR(dir))
> +		return PTR_ERR(dir);
> +	debugfs_create_file("divisor", S_IRUGO | S_IWUSR, dir, port,
> +							&ssi_sst_div_fops);

Here, too.

> +	dev_dbg(&ssi->device, "TX div %d for fck_rate %lu Khz speed %d Kb/s\n",
> +			tx_fckrate / omap_ssi->max_speed, omap_ssi->fck_rate,
> +							omap_ssi->max_speed);

...and here.

> +	if (--omap_port->wk_refcount) {
> +		spin_unlock_bh(&omap_port->wk_lock);
> +		return 0;
> +	}
> +	writel(SSI_WAKE(0),
> +				omap_ssi->sys + SSI_CLEAR_WAKE_REG(port->num));

...and here. Should be on one line, AFAICT.
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html