public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi@ti.com>
To: Gregory CLEMENT <gregory.clement@free-electrons.com>
Cc: Mathias Nyman <mathias.nyman@intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
	Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
	Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
	<linux-arm-kernel@lists.infradead.org>,
	Lior Amsalem <alior@marvell.com>,
	Tawfik Bayouk <tawfik@marvell.com>,
	Nadav Haklai <nadavh@marvell.com>,
	Grant Likely <grant.likely@linaro.org>,
	Rob Herring <robh+dt@kernel.org>, <devicetree@vger.kernel.org>
Subject: Re: [PATCH 3/8] xhci-platform: Add a new controller using xhci: Armada 38x
Date: Sat, 19 Apr 2014 22:21:59 -0500	[thread overview]
Message-ID: <20140420032159.GC26893@saruman.home> (raw)
In-Reply-To: <1397816563-9000-4-git-send-email-gregory.clement@free-electrons.com>

[-- Attachment #1: Type: text/plain, Size: 1205 bytes --]

On Fri, Apr 18, 2014 at 12:22:38PM +0200, Gregory CLEMENT wrote:
> Extend the compatible string list with xhci-armada-380. It is used to
> describe xhci controller which is in the Armada 38x SoCs.
> 
> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
> ---
>  Documentation/devicetree/bindings/usb/usb-xhci.txt | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/usb/usb-xhci.txt b/Documentation/devicetree/bindings/usb/usb-xhci.txt
> index 90f8f607d125..c49c14037afe 100644
> --- a/Documentation/devicetree/bindings/usb/usb-xhci.txt
> +++ b/Documentation/devicetree/bindings/usb/usb-xhci.txt
> @@ -1,7 +1,8 @@
>  USB xHCI controllers
>  
>  Required properties:
> -  - compatible: should be "generic-xhci" (deprecated: "xhci-platform").
> +  - compatible: should be on of "generic-xhci",

should be "one" of.

> +    "marvell,xhci-armada-380" (deprecated: "xhci-platform").

and this gives me a better idea, instead of using the quirk I suggested
before, match against this compatible:

	if (of_device_is_compatible(dev, "marvell,xhci-armada-380")
		xhci_marvel_mbus_init_quirk(dev);

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2014-04-20  3:24 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-18 10:22 [PATCH 0/8] USB3 support for Armada 38x Gregory CLEMENT
2014-04-18 10:22 ` [PATCH 1/8] usb: host: xhci-plat: Allow to register glue code using the device tree Gregory CLEMENT
2014-04-20  3:15   ` Felipe Balbi
2014-04-18 10:22 ` [PATCH 2/8] usb: host: xhci-plat: Add support for the Armada 38x glue code Gregory CLEMENT
2014-04-18 11:13   ` Sebastian Hesselbarth
2014-04-18 11:43     ` Gregory CLEMENT
2014-04-18 11:47       ` Sebastian Hesselbarth
2014-04-20  3:20   ` Felipe Balbi
2014-04-23  7:44     ` Gregory CLEMENT
2014-04-23 15:22       ` Felipe Balbi
2014-04-18 10:22 ` [PATCH 3/8] xhci-platform: Add a new controller using xhci: Armada 38x Gregory CLEMENT
2014-04-20  3:21   ` Felipe Balbi [this message]
2014-04-18 10:22 ` [PATCH 4/8] ARM: mvebu: Add USB3 UTMI support Gregory CLEMENT
2014-04-18 11:19   ` Sebastian Hesselbarth
2014-04-18 12:19     ` Gregory CLEMENT
2014-04-20  3:22   ` Felipe Balbi
2014-04-18 10:22 ` [PATCH 5/8] ARM: mvebu: Add Device Tree description of xHCI hosts on Armada 38x Gregory CLEMENT
2014-04-18 11:23   ` Sebastian Hesselbarth
2014-04-18 11:45     ` Gregory CLEMENT
2014-04-18 10:22 ` [PATCH 6/8] ARM: mvebu: Add USB3 support for " Gregory CLEMENT
2014-04-18 10:22 ` [PATCH 7/8] ARM: configs: Add usb_xhci_mvebu to mvebu_v7_defconfig Gregory CLEMENT
2014-04-18 10:22 ` [PATCH 8/8] ARM: configs: Add usb_xhci_mvebu to multi_v7_defconfig Gregory CLEMENT

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140420032159.GC26893@saruman.home \
    --to=balbi@ti.com \
    --cc=alior@marvell.com \
    --cc=andrew@lunn.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=ezequiel.garcia@free-electrons.com \
    --cc=grant.likely@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=gregory.clement@free-electrons.com \
    --cc=jason@lakedaemon.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@intel.com \
    --cc=nadavh@marvell.com \
    --cc=robh+dt@kernel.org \
    --cc=sebastian.hesselbarth@gmail.com \
    --cc=tawfik@marvell.com \
    --cc=thomas.petazzoni@free-electrons.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox