Re: [git pull] drm fixes

Woody Suwalski
2014-04-25T22:09:50Z

Christian König wrote:
> Am 23.04.2014 23:36, schrieb Woody Suwalski:
>> Dave Airlie wrote:
>>> On Wed, Apr 23, 2014 at 1:59 AM, Linus Torvalds
>>> <torvalds@linux-foundation.org> wrote:
>>>> Dave, mind sending me a pull request for drm fixes?
>>>>
>>>> There's now at least these two:
>>>>
>>>> - "drm/radeon/aux: fix hpd assignment for aux bus"
>>>> - "drm/radeon: use fixed PPL ref divider if needed"
>>>>
>>>> that look like fairly fatal regressions when they affect somebody.
>>>>
>>>> The fact that we already had *two* independent bugs be reported within
>>>> days of that last out-of-merge-window pull request makes me very
>>>> unhappy with the state of drm pulls.
>>>>
>>>> So please make sure that future fixes really are *fixes*. For
>>>> regressions only. No more games like this.
>>> The pll fallout is fixes for the initial feature that was in the
>>> merge window,
>>> Tuning plls for monitors is always a pain in the ass, the previous
>>> algorithm
>>> took a couple of kernels a few years back to get where it was,
>>> unfortunately
>>> HDMI came along and showed up a bunch of its shortcomings. I'm happy
>>> Alex and Christian are on top of things in terms of tracking
>>> regressions
>>> and making sure they get fixed,
>>>
>>> the AUX fix yes I'm a bit pissed off about myself, but I missed a pull
>>> from a few
>>> weeks ago, felt guilty, and maybe should have chosen the other path
>>> and let it
>>> wait a merge,
>>>
>>> Christian just sent me a -fixes pull with all of these in it and I'll
>>> send it on to you
>>> in a few mins.
>>>
>>> Dave.
>>>
>> That patch also fixes a shimmering (water floating) issue on Radeon
>> RV635 (Thinkpad T500)
>> 1002:9591
>
> Was this a long outstanding bug or a regression introduced with one of
> the recent patches?
>
> Thanks for the info,
> Christian.
Regression from 3.15-rc1 (still OK in -rc1, shimmering in -rc2)
Woody