Re: [PATCH 1/3] crypto: Fix potential leak in test_aead_speed() if aad_size is too big

Christian Engelmayer
2014-04-23T17:43:55Z

[-- Attachment #1: Type: text/plain, Size: 612 bytes --]

On Wed, 23 Apr 2014 01:33:05 +0200, Marek Vasut <marex@denx.de> wrote:
> On Monday, April 21, 2014 at 08:45:59 PM, Christian Engelmayer wrote:
> > + if (aad_size >= PAGE_SIZE) {
>
> On an unrelated note ... Won't if (aad_size > PAGE_SIZE) be sufficient here?

From what I have seen how the buffers are allocated via __get_free_page() I
thought so too. However, as it previously read

if (aad_size < PAGE_SIZE)
memset(assoc, 0xff, aad_size);
else {

my intention was simply to make the modification so that the bug is addressed
without introducing an additional change.

Regards,
Christian

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]