From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754480AbaDVJRo (ORCPT ); Tue, 22 Apr 2014 05:17:44 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:44566 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752225AbaDVJRl (ORCPT ); Tue, 22 Apr 2014 05:17:41 -0400 Date: Tue, 22 Apr 2014 12:16:56 +0300 From: Dan Carpenter To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Pavel Machek , hans.verkuil@cisco.com, m.chehab@samsung.com, ext-eero.nurkkala@nokia.com, nils.faerber@kernelconcepts.de, joni.lapilainen@gmail.com, freemangordon@abv.bg, sre@ring0.de, Greg KH , trivial@kernel.org, kernel list Subject: Re: [PATCH] radio-bcm2048.c: fix wrong overflow check Message-ID: <20140422091656.GV4963@mwanda> References: <20140420145622.GA15567@amd.pavel.ucw.cz> <20140422083917.GS4963@mwanda> <201404221055.54799@pali> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <201404221055.54799@pali> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: ucsinet22.oracle.com [156.151.31.94] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 22, 2014 at 10:55:53AM +0200, Pali Rohár wrote: > On Tuesday 22 April 2014 10:39:17 Dan Carpenter wrote: > > On Sun, Apr 20, 2014 at 04:56:22PM +0200, Pavel Machek wrote: > > > Fix wrong overflow check in radio-bcm2048. > > > > > > Signed-off-by: Pali Rohár > > > Signed-off-by: Pavel Machek > > > > Signed off means like you're signing a legal document to show > > that you didn't do anything illegal when you handled the > > patch. Was this patch authored by Pali? If so, then use the > > From: header. > > > > Btw, I reported this bug on Dec 10 last year. It's better > > that we fix it now than not fix it at all but we could have > > done better. Was the kbuild-zero-day bug report format > > confusing or how could I have helped out there? > > > > regards, > > dan carpenter > > Hello, I sent this patch months ago, but not generated by > commmand git format-patch. You should still have recieved authorship credit instead of Pavel. It's a newbie mistake which I have made myself. Pavel, use the From: header to give authorship credit. It goes on the first line of the email. Did you send it to the correct list? This patch should have gone to linux-media@vger.kernel.org. I see now that they are not CC'd. Please resend it to the correct list. > And yes, this problem was reported by some public static code checker. I was the public static code checker and I sent the bug report from my @oracle.com email address. Please, give me a Reported-by credit since you are resending this patch anyway. regards, dan carpenter