From: "Pali Rohár" <pali.rohar@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Pavel Machek <pavel@ucw.cz>,
hans.verkuil@cisco.com, m.chehab@samsung.com,
ext-eero.nurkkala@nokia.com, nils.faerber@kernelconcepts.de,
joni.lapilainen@gmail.com, freemangordon@abv.bg, sre@ring0.de,
Greg KH <greg@kroah.com>,
trivial@kernel.org, kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] radio-bcm2048.c: fix wrong overflow check
Date: Tue, 22 Apr 2014 10:55:53 +0200 [thread overview]
Message-ID: <201404221055.54799@pali> (raw)
In-Reply-To: <20140422083917.GS4963@mwanda>
[-- Attachment #1: Type: Text/Plain, Size: 966 bytes --]
On Tuesday 22 April 2014 10:39:17 Dan Carpenter wrote:
> On Sun, Apr 20, 2014 at 04:56:22PM +0200, Pavel Machek wrote:
> > Fix wrong overflow check in radio-bcm2048.
> >
> > Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
> > Signed-off-by: Pavel Machek <pavel@ucw.cz>
>
> Signed off means like you're signing a legal document to show
> that you didn't do anything illegal when you handled the
> patch. Was this patch authored by Pali? If so, then use the
> From: header.
>
> Btw, I reported this bug on Dec 10 last year. It's better
> that we fix it now than not fix it at all but we could have
> done better. Was the kbuild-zero-day bug report format
> confusing or how could I have helped out there?
>
> regards,
> dan carpenter
Hello, I sent this patch months ago, but not generated by
commmand git format-patch. And yes, this problem was reported by
some public static code checker.
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2014-04-22 8:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-20 14:56 [PATCH] radio-bcm2048.c: fix wrong overflow check Pavel Machek
2014-04-22 8:39 ` Dan Carpenter
2014-04-22 8:55 ` Pali Rohár [this message]
2014-04-22 9:16 ` Dan Carpenter
2014-04-22 9:38 ` Pavel Machek
2014-04-22 9:47 ` Pali Rohár
2014-04-22 12:57 ` [PATCH v2] " Dan Carpenter
2014-04-22 15:02 ` [PATCH v3] [media] radio-bcm2048: " Dan Carpenter
2014-05-05 13:34 ` [PATCH v2] radio-bcm2048.c: " Jiri Kosina
2014-05-09 16:10 ` Pali Rohár
2014-05-09 17:13 ` Hans Verkuil
2014-05-11 21:06 ` Jiri Kosina
2014-04-22 13:02 ` [PATCH] " Dan Carpenter
2014-04-22 16:41 ` Greg KH
2014-04-22 10:06 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201404221055.54799@pali \
--to=pali.rohar@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=ext-eero.nurkkala@nokia.com \
--cc=freemangordon@abv.bg \
--cc=greg@kroah.com \
--cc=hans.verkuil@cisco.com \
--cc=joni.lapilainen@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=nils.faerber@kernelconcepts.de \
--cc=pavel@ucw.cz \
--cc=sre@ring0.de \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox