From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755608AbaDVJrU (ORCPT ); Tue, 22 Apr 2014 05:47:20 -0400 Received: from mail-ee0-f54.google.com ([74.125.83.54]:34518 "EHLO mail-ee0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755132AbaDVJrL (ORCPT ); Tue, 22 Apr 2014 05:47:11 -0400 From: Pali =?utf-8?q?Roh=C3=A1r?= To: Pavel Machek Subject: Re: [PATCH] radio-bcm2048.c: fix wrong overflow check Date: Tue, 22 Apr 2014 11:47:05 +0200 User-Agent: KMail/1.13.7 (Linux/3.15.0-031500rc2-generic; KDE/4.12.3; x86_64; ; ) Cc: Dan Carpenter , hans.verkuil@cisco.com, m.chehab@samsung.com, ext-eero.nurkkala@nokia.com, nils.faerber@kernelconcepts.de, joni.lapilainen@gmail.com, freemangordon@abv.bg, sre@ring0.de, Greg KH , trivial@kernel.org, kernel list , linux-media@vger.kernel.org References: <20140420145622.GA15567@amd.pavel.ucw.cz> <20140422091656.GV4963@mwanda> <20140422093836.GA16686@amd.pavel.ucw.cz> In-Reply-To: <20140422093836.GA16686@amd.pavel.ucw.cz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1832675.KFpLFIzXl0"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201404221147.05726@pali> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --nextPart1832675.KFpLFIzXl0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Tuesday 22 April 2014 11:38:36 Pavel Machek wrote: > On Tue 2014-04-22 12:16:56, Dan Carpenter wrote: > > On Tue, Apr 22, 2014 at 10:55:53AM +0200, Pali Roh=C3=A1r wrote: > > > On Tuesday 22 April 2014 10:39:17 Dan Carpenter wrote: > > > > On Sun, Apr 20, 2014 at 04:56:22PM +0200, Pavel Machek=20 wrote: > > > > > Fix wrong overflow check in radio-bcm2048. > > > > >=20 > > > > > Signed-off-by: Pali Roh=C3=A1r > > > > > Signed-off-by: Pavel Machek > > > >=20 > > > > Signed off means like you're signing a legal document to > > > > show that you didn't do anything illegal when you > > > > handled the patch. Was this patch authored by Pali?=20 > > > > If so, then use the From: header. > > > >=20 > > > > Btw, I reported this bug on Dec 10 last year. It's > > > > better that we fix it now than not fix it at all but we > > > > could have done better. Was the kbuild-zero-day bug > > > > report format confusing or how could I have helped out > > > > there? > > > >=20 > > > > regards, > > > > dan carpenter > > >=20 > > > Hello, I sent this patch months ago, but not generated by > > > commmand git format-patch. > >=20 > > You should still have recieved authorship credit instead of > > Pavel. It's a newbie mistake which I have made myself.=20 > > Pavel, use the From: header to give authorship credit. It > > goes on the first line of the email. > >=20 > > Did you send it to the correct list? This patch should have > > gone to linux-media@vger.kernel.org. I see now that they > > are not CC'd. Please resend it to the correct list. >=20 > How many more mails need to be generated for single line > trivial patch? It is staging driver, so Greg should take it. > Anyway, cc-ed the list now. >=20 > > > And yes, this problem was reported by some public static > > > code checker. > >=20 > > I was the public static code checker and I sent the bug > > report from my @oracle.com email address. Please, give me > > a Reported-by credit since you are resending this patch > > anyway. >=20 > Feel free to resubmit the patch yourself. >=20 > Pavel I agree with Pavel, this patch which fixing buffer overflow bug=20 should have been already included in kernel tree. And I think it=20 really does not matter which from, to or cc lines are specified=20 for singleline patch which was inspirated by static code checker.=20 Rather to have fixed bug as talking who found it or who fixed it. =2D-=20 Pali Roh=C3=A1r pali.rohar@gmail.com --nextPart1832675.KFpLFIzXl0 Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEABECAAYFAlNWOpkACgkQi/DJPQPkQ1JleQCdH4yrV+uY0zd3MEIIb4d0kbYl /6oAoLLS7auQ63/cWvtRfxu4ZH6KIPHR =9KVT -----END PGP SIGNATURE----- --nextPart1832675.KFpLFIzXl0--