From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755567AbaDVTP0 (ORCPT ); Tue, 22 Apr 2014 15:15:26 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:53226 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755436AbaDVTPW (ORCPT ); Tue, 22 Apr 2014 15:15:22 -0400 X-Sasl-enc: rIX1aBPg7OdENYV8WbVPDd/bRlLjrVxYhFHu5nsuckAM 1398194121 Date: Tue, 22 Apr 2014 09:41:34 -0700 From: Greg KH To: Pavel Machek Cc: Dan Carpenter , Pali =?iso-8859-1?Q?Roh=E1r?= , hans.verkuil@cisco.com, m.chehab@samsung.com, ext-eero.nurkkala@nokia.com, nils.faerber@kernelconcepts.de, joni.lapilainen@gmail.com, freemangordon@abv.bg, sre@ring0.de, trivial@kernel.org, kernel list , linux-media@vger.kernel.org Subject: Re: [PATCH] radio-bcm2048.c: fix wrong overflow check Message-ID: <20140422164133.GA31976@kroah.com> References: <20140420145622.GA15567@amd.pavel.ucw.cz> <20140422083917.GS4963@mwanda> <201404221055.54799@pali> <20140422091656.GV4963@mwanda> <20140422093836.GA16686@amd.pavel.ucw.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20140422093836.GA16686@amd.pavel.ucw.cz> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 22, 2014 at 11:38:36AM +0200, Pavel Machek wrote: > On Tue 2014-04-22 12:16:56, Dan Carpenter wrote: > > On Tue, Apr 22, 2014 at 10:55:53AM +0200, Pali Rohár wrote: > > > On Tuesday 22 April 2014 10:39:17 Dan Carpenter wrote: > > > > On Sun, Apr 20, 2014 at 04:56:22PM +0200, Pavel Machek wrote: > > > > > Fix wrong overflow check in radio-bcm2048. > > > > > > > > > > Signed-off-by: Pali Rohár > > > > > Signed-off-by: Pavel Machek > > > > > > > > Signed off means like you're signing a legal document to show > > > > that you didn't do anything illegal when you handled the > > > > patch. Was this patch authored by Pali? If so, then use the > > > > From: header. > > > > > > > > Btw, I reported this bug on Dec 10 last year. It's better > > > > that we fix it now than not fix it at all but we could have > > > > done better. Was the kbuild-zero-day bug report format > > > > confusing or how could I have helped out there? > > > > > > > > regards, > > > > dan carpenter > > > > > > Hello, I sent this patch months ago, but not generated by > > > commmand git format-patch. > > > > You should still have recieved authorship credit instead of Pavel. It's > > a newbie mistake which I have made myself. Pavel, use the From: header > > to give authorship credit. It goes on the first line of the email. > > > > Did you send it to the correct list? This patch should have gone to > > linux-media@vger.kernel.org. I see now that they are not CC'd. Please > > resend it to the correct list. > > How many more mails need to be generated for single line trivial > patch? It is staging driver, so Greg should take it. Anyway, cc-ed the > list now. I don't take drivers/staging/media/ patches, please use get_maintainer.pl to see who does. greg k-h