From: Alexander Aring <alex.aring@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "Luis R. Rodriguez" <mcgrof@suse.com>,
"Luis R. Rodriguez" <mcgrof@do-not-panic.com>,
alex.bluesman.smirnov@gmail.com, dbaryshkov@gmail.com,
linux-zigbee-devel@lists.sourceforge.net, davem@davemloft.net,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
backports@vger.kernel.org
Subject: Re: [PATCH 1/3] 6lowpan: add helper to get 6lowpan namespace
Date: Tue, 22 Apr 2014 20:49:10 +0200 [thread overview]
Message-ID: <20140422184908.GA16477@omega> (raw)
In-Reply-To: <1398192315.4211.25.camel@jlt4.sipsolutions.net>
On Tue, Apr 22, 2014 at 08:45:15PM +0200, Johannes Berg wrote:
> On Tue, 2014-04-22 at 19:58 +0200, Luis R. Rodriguez wrote:
>
> > > > > +#if IS_ENABLED(CONFIG_IEEE802154_6LOWPAN)
> > > > > [...]
> > > > > +#else
> > > > > +static inline struct netns_ieee802154_lowpan *
> > > > > +net_ieee802154_lowpan(struct net *net)
> > > > > +{
> > > > > + return NULL;
> > > > > +}
> > > > > +#endif
> > > >
> > > > Why would that be needed? If nobody compiles 802.15.4 then it seems
> > > > nothing should reference it?
> > > >
> > > Indeed I think this is unnecessary, also.
> >
> > I wanted to be sure, and I was not. Right now 6lowpan does not depend
> > on CONFIG_NET_NS, is this intentional? I think its fine without it
> > but I was not sure.
>
> I fail to see how !CONFIG_LOWPAN is related CONFIG_NET_NS?
>
mhh, IEEE802154_6LOWPAN depends on IPV6 and I think IPV6 is related to
CONFIG_NET_NS.
- Alex
next prev parent reply other threads:[~2014-04-22 18:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-18 1:22 [PATCH 0/3] 6lowpan: few changes to help with backports Luis R. Rodriguez
2014-04-18 1:22 ` [PATCH 1/3] 6lowpan: add helper to get 6lowpan namespace Luis R. Rodriguez
2014-04-22 9:44 ` Johannes Berg
2014-04-22 9:53 ` Alexander Aring
2014-04-22 17:58 ` Luis R. Rodriguez
2014-04-22 18:45 ` Johannes Berg
2014-04-22 18:49 ` Alexander Aring [this message]
2014-04-22 19:09 ` Luis R. Rodriguez
2014-04-22 19:03 ` Luis R. Rodriguez
2014-04-18 1:22 ` [PATCH 2/3] 6lowpan: make lowpan_cb static Luis R. Rodriguez
2014-04-18 1:22 ` [PATCH 3/3] 6lowpan: include net/net_namespace.h on 6lowpan namepsace header Luis R. Rodriguez
2014-04-20 22:21 ` [PATCH 0/3] 6lowpan: few changes to help with backports David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140422184908.GA16477@omega \
--to=alex.aring@gmail.com \
--cc=alex.bluesman.smirnov@gmail.com \
--cc=backports@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=dbaryshkov@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-zigbee-devel@lists.sourceforge.net \
--cc=mcgrof@do-not-panic.com \
--cc=mcgrof@suse.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox