From: Don Zickus <dzickus@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
x86@kernel.org, davem@davemloft.net, sparclinux@vger.kernel.org,
mguzik@redhat.com
Subject: Re: [PATCH 0/4 V3] Print traces on softlockup
Date: Tue, 22 Apr 2014 15:09:35 -0400 [thread overview]
Message-ID: <20140422190935.GL8488@redhat.com> (raw)
In-Reply-To: <20140422112828.ea511cefa17affb99d9aa97f@linux-foundation.org>
On Tue, Apr 22, 2014 at 11:28:28AM -0700, Andrew Morton wrote:
> On Tue, 22 Apr 2014 11:17:24 -0400 Don Zickus <dzickus@redhat.com> wrote:
>
> > Added more patches to handle the 'uniprocessor' panic case by sending NMIs
> > to every cpu but self. Only affects x86, sparc.
> >
>
> Looks OK to me. A couple of things:
>
> - Patches 1-3 should be combined so we don't create bisection holes
> due to x86 and sparc build errors.
ok.
>
> - Patch 4 adds stuff which is unusable on uniprocessor, especially
> the presence of /proc/sys/kernel/softlockup_all_cpu_backtrace. We
> already have #ifdef CONFIG_SMP in kern_table, so do more of that?
I can resubmit that patch with CONFIG_SMP around each piece of that patch.
Thanks for the review.
Cheers,
Don
next prev parent reply other threads:[~2014-04-22 19:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-22 15:17 [PATCH 0/4 V3] Print traces on softlockup Don Zickus
2014-04-22 15:17 ` [PATCH 1/4 v3] nmi: Provide the option to issue an NMI back trace to every cpu but current Don Zickus
2014-04-22 15:17 ` [PATCH 2/4 v3] x86, nmi: Add more flexible NMI back trace support Don Zickus
2014-04-22 15:17 ` [PATCH 3/4 v3] sparc64, " Don Zickus
2014-04-22 15:17 ` [PATCH 4/4 v3] watchdog: Printing traces for all cpus on lockup detection Don Zickus
2014-04-22 18:28 ` [PATCH 0/4 V3] Print traces on softlockup Andrew Morton
2014-04-22 19:09 ` Don Zickus [this message]
2014-04-23 19:22 ` Don Zickus
2014-04-23 19:35 ` Andrew Morton
2014-04-23 20:44 ` Don Zickus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140422190935.GL8488@redhat.com \
--to=dzickus@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mguzik@redhat.com \
--cc=sparclinux@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox