From: Peter Zijlstra <peterz@infradead.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Jiang Liu <jiang.liu@linux.intel.com>,
Ingo Molnar <mingo@kernel.org>, Ingo Molnar <mingo@redhat.com>,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
Tony Luck <tony.luck@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [Bugfix] sched: fix possible invalid memory access caused by CPU hot-addition
Date: Tue, 22 Apr 2014 22:04:49 +0200 [thread overview]
Message-ID: <20140422200449.GF11096@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20140422130151.83bc4539364ca660c68de859@linux-foundation.org>
On Tue, Apr 22, 2014 at 01:01:51PM -0700, Andrew Morton wrote:
> On Tue, 22 Apr 2014 10:15:15 +0200 Peter Zijlstra <peterz@infradead.org> wrote:
>
> > On Tue, Apr 22, 2014 at 01:27:15PM +0800, Jiang Liu wrote:
> > > When calling kzalloc_node(size, flags, node), we should first check
> > > whether node is onlined, otherwise it may cause invalid memory access
> > > as below.
> >
> > But this is only for memory less node crap, right?
>
> um, why are memoryless nodes crap?
Why wouldn't they be? Having CPUs with no local memory seems decidedly
suboptimal.
next prev parent reply other threads:[~2014-04-22 20:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-22 5:27 [Bugfix] sched: fix possible invalid memory access caused by CPU hot-addition Jiang Liu
2014-04-22 8:15 ` Peter Zijlstra
2014-04-22 20:01 ` Andrew Morton
2014-04-22 20:04 ` Peter Zijlstra [this message]
2014-04-23 1:59 ` David Rientjes
2014-04-23 4:53 ` Jiang Liu
2014-04-23 2:05 ` Mike Galbraith
2014-04-23 2:45 ` Jiang Liu
2014-04-23 5:32 ` Peter Zijlstra
2014-04-23 5:45 ` Jiang Liu
2014-04-23 5:51 ` Peter Zijlstra
2014-04-23 17:46 ` Luck, Tony
2014-04-24 2:59 ` Jiang Liu
2014-04-24 7:47 ` Peter Zijlstra
2014-04-24 17:41 ` Luck, Tony
2014-04-24 19:09 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140422200449.GF11096@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=jiang.liu@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=rafael.j.wysocki@intel.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox