From: Tejun Heo <tj@kernel.org>
To: Jianyu Zhan <nasa4836@gmail.com>
Cc: lizefan@huawei.com, containers@lists.linux-foundation.org,
cgroups@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] cgroup: introduce helper css_to_id()
Date: Tue, 22 Apr 2014 16:31:26 -0400 [thread overview]
Message-ID: <20140422203126.GD2314@mtj.dyndns.org> (raw)
In-Reply-To: <0414ce4418a6f0dd481586ce4059b97800bcc1ca.1398147734.git.nasa4836@gmail.com>
On Tue, Apr 22, 2014 at 02:30:27PM +0800, Jianyu Zhan wrote:
> This is a prepared patch for converting from per-cgroup id to
> per-subsystem id.
>
> Some subsystems dereference the per-cgrpu id directly, but this is
> implementation-specific, so it should be transparent for subsystems.
Hmm... why would cgroup ID be implementation-specific? It's a
published field
> Use this accessor instead.
I'm not a big believer of trivial accessors. They tend to obfuscate
things more than helping anything. Here, we need to switch from
cgrp->id to css->id. Wrapping cgrp->id by css_to_id() doesn't really
help anything especially because there will be cases where we'd
actually want cgroup IDs instead of css IDs too.
Thanks.
--
tejun
next prev parent reply other threads:[~2014-04-22 20:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-22 6:30 [PATCH 0/4] cgroup: substitude per-cgroup id with per-subsys id Jianyu Zhan
2014-04-22 6:30 ` [PATCH 1/4] cgroup: introduce helper css_to_id() Jianyu Zhan
2014-04-22 20:31 ` Tejun Heo [this message]
2014-04-22 6:30 ` [PATCH 2/4] mm/memcontrol.c: use accessor to get id from css Jianyu Zhan
2014-04-22 7:03 ` Jianyu Zhan
2014-04-22 8:08 ` Jianyu Zhan
2014-04-22 10:01 ` Michal Hocko
[not found] ` <20140422124920.e22ed65d33d2b982ef467372@linux-foundation.org>
2014-04-23 6:41 ` Jianyu Zhan
2014-04-22 6:31 ` [PATCH 3/4] netprio_cgroup: " Jianyu Zhan
2014-04-22 11:27 ` Neil Horman
2014-04-22 20:33 ` Tejun Heo
2014-04-22 6:31 ` [PATCH 4/4] cgroup: convert from per-cgroup id to per-subsys id Jianyu Zhan
2014-04-22 8:03 ` Jianyu Zhan
2014-04-22 20:36 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140422203126.GD2314@mtj.dyndns.org \
--to=tj@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=containers@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=nasa4836@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox