From: Dave Chinner <david@fromorbit.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Fabian Frederick <fabf@skynet.be>,
linux-kernel <linux-kernel@vger.kernel.org>,
hch <hch@infradead.org>
Subject: Re: [PATCH 1/1] fs/xfs/xfs_log.c: Fix comparison to bool
Date: Wed, 23 Apr 2014 11:58:03 +1000 [thread overview]
Message-ID: <20140423015803.GH15995@dastard> (raw)
In-Reply-To: <20140416151557.ac032e9621027faa8fc7f86d@linux-foundation.org>
On Wed, Apr 16, 2014 at 03:15:57PM -0700, Andrew Morton wrote:
> On Sun, 13 Apr 2014 22:09:17 +0200 Fabian Frederick <fabf@skynet.be> wrote:
>
> > Fixing coccinelle warning
>
> Please always quote the full error message or warning text when fixing
> such things.
And CC the correct lists (xfs@oss.sgi.com) and/or the subsystem
maintainer (me). LKML is extremely lossy - I got behind on reading
it and so simply deleted the 10,000 queued emails, one of which was
this patch....
> > --- a/fs/xfs/xfs_log.c
> > +++ b/fs/xfs/xfs_log.c
> > @@ -2376,7 +2376,7 @@ next_lv:
> > if (lv)
> > vecp = lv->lv_iovecp;
> > }
> > - if (record_cnt == 0 && ordered == false) {
> > + if (record_cnt == 0 && !ordered) {
> > if (!lv)
> > return 0;
>
> There was nothing wrong with that code. I suspect coccinelle bustage.
Agreed, especially given that the variable is declared as:
bool ordered = false;
So it can only have the values of false and true....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2014-04-23 1:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-13 20:09 [PATCH 1/1] fs/xfs/xfs_log.c: Fix comparison to bool Fabian Frederick
2014-04-16 22:15 ` Andrew Morton
2014-04-16 22:47 ` Joe Perches
2014-04-23 1:58 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140423015803.GH15995@dastard \
--to=david@fromorbit.com \
--cc=akpm@linux-foundation.org \
--cc=fabf@skynet.be \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox